* [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared.
@ 2012-09-19 23:33 Fengguang Wu
2012-09-20 14:21 ` [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla Samuel Ortiz
2012-09-20 15:48 ` Stephen Warren
0 siblings, 2 replies; 3+ messages in thread
From: Fengguang Wu @ 2012-09-19 23:33 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]
Hi Stephen,
FYI, there are new sparse warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next
head: 144c94c99ad2f20ff37ca77147a10da7718895ad
commit: 9582fdcb6fcf1b596a83b161a2ea886272d2a62f [47/76] mfd: max8907: Add power off control
All sparse warnings:
+ drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared. Should it be static?
vim +179 drivers/mfd/max8907.c
169
170 static const struct regmap_irq_chip max8907_rtc_irq_chip = {
171 .name = "max8907 rtc",
172 .status_base = MAX8907_REG_RTC_IRQ,
173 .mask_base = MAX8907_REG_RTC_IRQ_MASK,
174 .num_regs = 1,
175 .irqs = max8907_rtc_irqs,
176 .num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
177 };
178
> 179 struct max8907 *max8907_pm_off;
180 static void max8907_power_off(void)
181 {
182 regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG,
183 MAX8907_MASK_POWER_OFF, MAX8907_MASK_POWER_OFF);
184 }
185
186 static __devinit int max8907_i2c_probe(struct i2c_client *i2c,
187 const struct i2c_device_id *id)
188 {
189 struct max8907 *max8907;
Please consider folding the attached diff :-)
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
[-- Attachment #2: make-it-static-9582fdc.diff --]
[-- Type: text/x-diff, Size: 462 bytes --]
diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index 2303641..17f2593 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -176,7 +176,7 @@ static const struct regmap_irq_chip max8907_rtc_irq_chip = {
.num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
};
-struct max8907 *max8907_pm_off;
+static struct max8907 *max8907_pm_off;
static void max8907_power_off(void)
{
regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG,
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla
2012-09-19 23:33 [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared Fengguang Wu
@ 2012-09-20 14:21 ` Samuel Ortiz
2012-09-20 15:48 ` Stephen Warren
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-09-20 14:21 UTC (permalink / raw)
To: kernel-janitors
Hi Fengguang,
On Thu, Sep 20, 2012 at 07:33:48AM +0800, Fengguang Wu wrote:
> Hi Stephen,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next
> head: 144c94c99ad2f20ff37ca77147a10da7718895ad
> commit: 9582fdcb6fcf1b596a83b161a2ea886272d2a62f [47/76] mfd: max8907: Add power off control
>
> All sparse warnings:
>
> + drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared. Should it be static?
>
> vim +179 drivers/mfd/max8907.c
> 169
> 170 static const struct regmap_irq_chip max8907_rtc_irq_chip = {
> 171 .name = "max8907 rtc",
> 172 .status_base = MAX8907_REG_RTC_IRQ,
> 173 .mask_base = MAX8907_REG_RTC_IRQ_MASK,
> 174 .num_regs = 1,
> 175 .irqs = max8907_rtc_irqs,
> 176 .num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
> 177 };
> 178
> > 179 struct max8907 *max8907_pm_off;
> 180 static void max8907_power_off(void)
> 181 {
> 182 regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG,
> 183 MAX8907_MASK_POWER_OFF, MAX8907_MASK_POWER_OFF);
> 184 }
> 185
> 186 static __devinit int max8907_i2c_probe(struct i2c_client *i2c,
> 187 const struct i2c_device_id *id)
> 188 {
> 189 struct max8907 *max8907;
>
> Please consider folding the attached diff :-)
I applied this one on top of my for-next branch. I took the freedom to add
your SOB on it, please let me know if that's an issue for you.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla
2012-09-19 23:33 [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared Fengguang Wu
2012-09-20 14:21 ` [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla Samuel Ortiz
@ 2012-09-20 15:48 ` Stephen Warren
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2012-09-20 15:48 UTC (permalink / raw)
To: kernel-janitors
Fengguang Wu wrote at Wednesday, September 19, 2012 5:34 PM:
> Hi Stephen,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next
> head: 144c94c99ad2f20ff37ca77147a10da7718895ad
> commit: 9582fdcb6fcf1b596a83b161a2ea886272d2a62f [47/76] mfd: max8907: Add power off control
>
> All sparse warnings:
>
> + drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared. Should it be static?
...
> Please consider folding the attached diff :-)
Yes, the diff is correct; please consider it:
Acked-by: Stephen Warren <swarren@nvidia.com>
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-20 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-19 23:33 [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared Fengguang Wu
2012-09-20 14:21 ` [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla Samuel Ortiz
2012-09-20 15:48 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox