From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Did I create this patch correctly (for checkpatch fixes)?
Date: Sun, 23 Sep 2012 16:15:43 +0000 [thread overview]
Message-ID: <20120923161543.GI4587@mwanda> (raw)
In-Reply-To: <CAFfwLZjWcBf+r_TTrsNTTdmhAHFPSkvmQ3F7nHOr+SV3Mj=_Lw@mail.gmail.com>
On Sun, Sep 23, 2012 at 09:13:05PM +0530, Harsh Kumar wrote:
> Hi,
>
> I have created a patch for the first time. It is a small change (only
> 3 line change). I ran checkpatch.pl on my patch file and there were no
> problems. But can somebody please tell me:
>
> 1.) Are the fixes for checkpatch.pl issues correct?
> 2.) Is the patch file correctly made?
I'm not sure what the problem was you were fixing. Only the third
line is correct.
The patch should be included in the email. It needs a proper
subject, a patch description and a Signed-off-by line.
Email the patch to yourself. Save the raw email including headers
and everything. `cat raw_email.txt | git am`. `git log -p`. Look
through the patch and verify that the patch description and
everything looks good.
regards,
dan carpenter
prev parent reply other threads:[~2012-09-23 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 15:55 Did I create this patch correctly (for checkpatch fixes)? Harsh Kumar
2012-09-23 16:15 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120923161543.GI4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox