Did I create this patch correctly (for checkpatch fixes)?

Did I create this patch correctly (for checkpatch fixes)?

[Harsh Kumar]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

Hi,

I have created a patch for the first time. It is a small change (only
3 line change). I ran checkpatch.pl on my patch file and there were no
problems. But can somebody please tell me:

1.) Are the fixes for checkpatch.pl issues correct?
2.) Is the patch file correctly made?

Thanks
Harsh Kumar

[-- Attachment #2: checkpatchfix_driverstaging.patch --]
[-- Type: application/octet-stream, Size: 1474 bytes --]

Drivers: Staging: checkpatch fixes for winbond/sme_api.h
Signed-off-by: Harsh Kumar <harsh1kumar@gmail.com>
diff -uNr linux-3.6-rc6.orig/drivers/staging/winbond/sme_api.h linux-3.6-rc6.new/drivers/staging/winbond/sme_api.h
--- linux-3.6-rc6.orig/drivers/staging/winbond/sme_api.h	2012-09-17 03:28:51.000000000 +0530
+++ linux-3.6-rc6.new/drivers/staging/winbond/sme_api.h	2012-09-23 14:25:02.688763002 +0530
@@ -12,7 +12,7 @@
 #include "localpara.h"
 
 /****************** CONSTANT AND MACRO SECTION ******************************/
-#define _INLINE				__inline
+#define _INLINE				inline
 
 #define MEDIA_STATE_DISCONNECTED	0
 #define MEDIA_STATE_CONNECTED		1
@@ -31,7 +31,7 @@
 
 /* OID_802_11_SSID */
 s8 sme_get_ssid(void *pcore_data, u8 *pssid, u8 *pssid_len);
-s8 sme_get_desired_ssid(void *pcore_data, u8 *pssid, u8 *pssid_len);/* Not use */
+s8 sme_get_desired_ssid(void *pcore_data, u8 *pssid, u8 *pssid_len);/*Not use*/
 s8 sme_set_desired_ssid(void *pcore_data, u8 *pssid, u8 ssid_len);
 
 /* OID_802_11_INFRASTRUCTURE_MODE */
@@ -138,7 +138,7 @@
 s8 sme_get_txrate_policy(void *pcore_data, u8 *policy);
 s8 sme_get_cwmin_value(void *pcore_data, u8 *cwmin);
 s8 sme_get_cwmax_value(void *pcore_data, u16 *cwmax);
-s8 sme_get_ms_radio_mode(void *pcore_data, u8 * pMsRadioOff);
+s8 sme_get_ms_radio_mode(void *pcore_data, u8 *pMsRadioOff);
 s8 sme_set_ms_radio_mode(void *pcore_data, u8 boMsRadioOff);
 
 void sme_get_tx_power_level(void *pcore_data, u32 *TxPower);

Re: Did I create this patch correctly (for checkpatch fixes)?

[Dan Carpenter]

On Sun, Sep 23, 2012 at 09:13:05PM +0530, Harsh Kumar wrote:
> Hi,
> 
> I have created a patch for the first time. It is a small change (only
> 3 line change). I ran checkpatch.pl on my patch file and there were no
> problems. But can somebody please tell me:
> 
> 1.) Are the fixes for checkpatch.pl issues correct?
> 2.) Is the patch file correctly made?

I'm not sure what the problem was you were fixing.  Only the third
line is correct.

The patch should be included in the email.  It needs a proper
subject, a patch description and a Signed-off-by line.

Email the patch to yourself.  Save the raw email including headers
and everything.  `cat raw_email.txt | git am`.  `git log -p`.  Look
through the patch and verify that the patch description and
everything looks good.

regards,
dan carpenter