* [patch] staging: rts5139: use kzalloc() to close an info leak
@ 2012-09-23 16:31 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-09-23 16:31 UTC (permalink / raw)
To: kernel-janitors
If we don't fill the whole buffer then there is information leaked to
the user.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Hopefully this is only reachable by root so it's probably not such a big
deal.
diff --git a/drivers/staging/rts5139/rts51x_fop.c b/drivers/staging/rts5139/rts51x_fop.c
index e1200fe..bf1a9e6 100644
--- a/drivers/staging/rts5139/rts51x_fop.c
+++ b/drivers/staging/rts5139/rts51x_fop.c
@@ -79,7 +79,7 @@ static int rts51x_sd_direct_cmnd(struct rts51x_chip *chip,
case 1:
/* Read from card */
- buf = kmalloc(cmnd->buf_len, GFP_KERNEL);
+ buf = kzalloc(cmnd->buf_len, GFP_KERNEL);
if (!buf)
TRACE_RET(chip, STATUS_NOMEM);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-09-23 16:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-23 16:31 [patch] staging: rts5139: use kzalloc() to close an info leak Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox