[tip:x86/acpi 2/6] arch/x86/kernel/setup.c:944:2: error: implicit declaration of function 'acpi_init

[tip:x86/acpi 2/6] arch/x86/kernel/setup.c:944:2: error: implicit declaration of function 'acpi_init

[Fengguang Wu]

Hi Thomas,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/acpi
head:   4901b402c957d4ebaff123ffc34fafe3cef99542
commit: 9b17afd44dadf5065c46bc8e4df55b938d92c529 [2/6] ACPI: Store valid ACPI tables passed via early initrd in reserved memblock areas
config: i386-allnoconfig

All error/warnings:

In file included from init/main.c:25:0:
include/linux/acpi.h:442:28: error: unknown type name 'acpi_physical_address'
--
In file included from arch/x86/kernel/setup.c:29:0:
include/linux/acpi.h:442:28: error: unknown type name 'acpi_physical_address'
arch/x86/kernel/setup.c: In function 'setup_arch':
arch/x86/kernel/setup.c:944:2: error: implicit declaration of function 'acpi_initrd_override' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

vim +944 arch/x86/kernel/setup.c

e7b37895  (Yinghai Lu       2008-06-25  938) #endif
162a7e75  (Mike Travis      2011-05-24  939) 	/* Allocate bigger log buffer */
162a7e75  (Mike Travis      2011-05-24  940) 	setup_log_buf(1);
e7b37895  (Yinghai Lu       2008-06-25  941) 
2ec65f8b  (Yinghai Lu       2008-06-23  942) 	reserve_initrd();
2ec65f8b  (Yinghai Lu       2008-06-23  943) 
9b17afd4  (Thomas Renninger 2012-09-26 @944) 	acpi_initrd_override((void *)initrd_start, initrd_end - initrd_start);
9b17afd4  (Thomas Renninger 2012-09-26  945) 
44280733  (Yinghai Lu       2009-11-22  946) 	reserve_crashkernel();
44280733  (Yinghai Lu       2009-11-22  947) 

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

Re: [tip:x86/acpi 2/6] arch/x86/kernel/setup.c:944:2: error: implicit declaration of function 'acpi_

[H. Peter Anvin]

Thank you, Fengguang!

Obviously, we will not push this version of this branch.

	-hpa

On 09/27/2012 07:46 PM, Fengguang Wu wrote:
> Hi Thomas,
> 
> FYI, kernel build failed on
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/acpi
> head:   4901b402c957d4ebaff123ffc34fafe3cef99542
> commit: 9b17afd44dadf5065c46bc8e4df55b938d92c529 [2/6] ACPI: Store valid ACPI tables passed via early initrd in reserved memblock areas
> config: i386-allnoconfig
> 
> All error/warnings:
> 
> In file included from init/main.c:25:0:
> include/linux/acpi.h:442:28: error: unknown type name 'acpi_physical_address'
> --
> In file included from arch/x86/kernel/setup.c:29:0:
> include/linux/acpi.h:442:28: error: unknown type name 'acpi_physical_address'
> arch/x86/kernel/setup.c: In function 'setup_arch':
> arch/x86/kernel/setup.c:944:2: error: implicit declaration of function 'acpi_initrd_override' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> 
> vim +944 arch/x86/kernel/setup.c
> 
> e7b37895  (Yinghai Lu       2008-06-25  938) #endif
> 162a7e75  (Mike Travis      2011-05-24  939) 	/* Allocate bigger log buffer */
> 162a7e75  (Mike Travis      2011-05-24  940) 	setup_log_buf(1);
> e7b37895  (Yinghai Lu       2008-06-25  941) 
> 2ec65f8b  (Yinghai Lu       2008-06-23  942) 	reserve_initrd();
> 2ec65f8b  (Yinghai Lu       2008-06-23  943) 
> 9b17afd4  (Thomas Renninger 2012-09-26 @944) 	acpi_initrd_override((void *)initrd_start, initrd_end - initrd_start);
> 9b17afd4  (Thomas Renninger 2012-09-26  945) 
> 44280733  (Yinghai Lu       2009-11-22  946) 	reserve_crashkernel();
> 44280733  (Yinghai Lu       2009-11-22  947) 
> 
> ---
> 0-DAY kernel build testing backend         Open Source Technology Centre
> Fengguang Wu, Yuanhan Liu                              Intel Corporation
> 

Re: [tip:x86/acpi 2/6] arch/x86/kernel/setup.c:944:2: error: implicit declaration of function 'acpi_

[Thomas Renninger]

Hi,

On Friday, September 28, 2012 07:42:49 AM H. Peter Anvin wrote:
> Thank you, Fengguang!
Yes, thanks!
> 
> Obviously, we will not push this version of this branch.

I obviously should have done this before:
I now removed the old version, I already had added to our
SUSE head branch and added this one.

This should trigger various .config compile options on different
architectures and when builds succeed, I will again post
(privately to hpa again) the patchset.

The bug was to put an empty declaration of:
static inline void arch_reserve_mem_area(acpi_physical_address addr,
                                          size_t size)
{
}
only into !CONFIG_X86 && CONFIG_ACPI defined area.
Result was that kernel did not build on X86 with ACPI not defined.

Another minor change I am going to add is to name the newly
introduced Kconfig option (bool "..."):

config ACPI_INITRD_TABLE_OVERRIDE
        bool "ACPI tables can be passed via uncompressed cpio in initrd"


Question:
Is there a way to get these test builds enabled on a git tree
hosted on git.kernel.org?
I now have an account and if there is some kind of such functionality
I would like to try this out...

Or maybe there is some toolkit so that I can clone my git tree locally
and initiate these test builds here locally?
That would make it easier to pre-test patches in various .configs before
submitting.

Thanks,

   Thomas