From: Josh Triplett <josh@joshtriplett.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [tip:x86/efi 7/11] include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not us
Date: Fri, 28 Sep 2012 19:16:29 +0000 [thread overview]
Message-ID: <20120928191629.GE5202@jtriplet-mobl1> (raw)
In-Reply-To: <20120928024115.GD9155@localhost>
On Fri, Sep 28, 2012 at 10:41:15AM +0800, Fengguang Wu wrote:
> include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not used
>
> vim +501 include/linux/efi.h
>
> f383a1e3 (Josh Triplett 2012-09-08 498) #ifdef CONFIG_X86
> ^1da177e (Linus Torvalds 2005-04-16 499) extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
> f383a1e3 (Josh Triplett 2012-09-08 500) #else
> f383a1e3 (Josh Triplett 2012-09-08 @501) static void efi_enter_virtual_mode(void) {}
> f383a1e3 (Josh Triplett 2012-09-08 502) #endif
On Fri, Sep 28, 2012 at 10:45:25AM +0800, Fengguang Wu wrote:
> include/linux/efi.h:503: warning: 'efi_enter_virtual_mode' defined but not used
> include/linux/efi.h:504: warning: 'efi_late_init' defined but not used
> include/linux/efi.h:505: warning: 'efi_free_boot_services' defined but not used
>
> vim +504 include/linux/efi.h
>
> f383a1e3 (Josh Triplett 2012-09-08 498) #ifdef CONFIG_X86
> ^1da177e (Linus Torvalds 2005-04-16 499) extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
> ba49efa1 (Josh Triplett 2012-09-08 500) extern void efi_late_init(void);
> 668b132e (Josh Triplett 2012-09-08 501) extern void efi_free_boot_services(void);
> f383a1e3 (Josh Triplett 2012-09-08 502) #else
> f383a1e3 (Josh Triplett 2012-09-08 503) static void efi_enter_virtual_mode(void) {}
> ba49efa1 (Josh Triplett 2012-09-08 @504) static void efi_late_init(void) {}
> 668b132e (Josh Triplett 2012-09-08 505) static void efi_free_boot_services(void) {}
>
> It's missing 'inline' in the above three lines.
Indeed; both of these come from the same issue. Will fix.
- Josh Triplett
prev parent reply other threads:[~2012-09-28 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 2:41 [tip:x86/efi 7/11] include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not used Fengguang Wu
2012-09-28 19:16 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928191629.GE5202@jtriplet-mobl1 \
--to=josh@joshtriplett.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox