* [tip:x86/efi 7/11] include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not used
@ 2012-09-28 2:41 Fengguang Wu
2012-09-28 19:16 ` [tip:x86/efi 7/11] include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not us Josh Triplett
0 siblings, 1 reply; 2+ messages in thread
From: Fengguang Wu @ 2012-09-28 2:41 UTC (permalink / raw)
To: kernel-janitors
Hi Josh,
FYI, there are new compile warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/efi
head: ba49efa14f97ca6fe57390539e70a359aea779cd
commit: f383a1e37bc3fc93d19ed23dfdb1adfc5a7d1010 [7/11] efi: Add a stub for efi_enter_virtual_mode on non-x86
config: avr32-atngw100_defconfig
All warnings:
include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not used
vim +501 include/linux/efi.h
f383a1e3 (Josh Triplett 2012-09-08 498) #ifdef CONFIG_X86
^1da177e (Linus Torvalds 2005-04-16 499) extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
f383a1e3 (Josh Triplett 2012-09-08 500) #else
f383a1e3 (Josh Triplett 2012-09-08 @501) static void efi_enter_virtual_mode(void) {}
f383a1e3 (Josh Triplett 2012-09-08 502) #endif
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tip:x86/efi 7/11] include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not us
2012-09-28 2:41 [tip:x86/efi 7/11] include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not used Fengguang Wu
@ 2012-09-28 19:16 ` Josh Triplett
0 siblings, 0 replies; 2+ messages in thread
From: Josh Triplett @ 2012-09-28 19:16 UTC (permalink / raw)
To: kernel-janitors
On Fri, Sep 28, 2012 at 10:41:15AM +0800, Fengguang Wu wrote:
> include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not used
>
> vim +501 include/linux/efi.h
>
> f383a1e3 (Josh Triplett 2012-09-08 498) #ifdef CONFIG_X86
> ^1da177e (Linus Torvalds 2005-04-16 499) extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
> f383a1e3 (Josh Triplett 2012-09-08 500) #else
> f383a1e3 (Josh Triplett 2012-09-08 @501) static void efi_enter_virtual_mode(void) {}
> f383a1e3 (Josh Triplett 2012-09-08 502) #endif
On Fri, Sep 28, 2012 at 10:45:25AM +0800, Fengguang Wu wrote:
> include/linux/efi.h:503: warning: 'efi_enter_virtual_mode' defined but not used
> include/linux/efi.h:504: warning: 'efi_late_init' defined but not used
> include/linux/efi.h:505: warning: 'efi_free_boot_services' defined but not used
>
> vim +504 include/linux/efi.h
>
> f383a1e3 (Josh Triplett 2012-09-08 498) #ifdef CONFIG_X86
> ^1da177e (Linus Torvalds 2005-04-16 499) extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */
> ba49efa1 (Josh Triplett 2012-09-08 500) extern void efi_late_init(void);
> 668b132e (Josh Triplett 2012-09-08 501) extern void efi_free_boot_services(void);
> f383a1e3 (Josh Triplett 2012-09-08 502) #else
> f383a1e3 (Josh Triplett 2012-09-08 503) static void efi_enter_virtual_mode(void) {}
> ba49efa1 (Josh Triplett 2012-09-08 @504) static void efi_late_init(void) {}
> 668b132e (Josh Triplett 2012-09-08 505) static void efi_free_boot_services(void) {}
>
> It's missing 'inline' in the above three lines.
Indeed; both of these come from the same issue. Will fix.
- Josh Triplett
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-28 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-28 2:41 [tip:x86/efi 7/11] include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not used Fengguang Wu
2012-09-28 19:16 ` [tip:x86/efi 7/11] include/linux/efi.h:501: warning: 'efi_enter_virtual_mode' defined but not us Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox