public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] ocfs2/dlm: small signedness bug in dlm_request_all_locks()
@ 2012-10-02  8:29 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-10-02  8:29 UTC (permalink / raw)
  To: kernel-janitors

"ret" is used to store the return value of o2net_send_message(), and not
an enum dlm_status.  Because of the type difference, if an error
happened then the check for (ret < 0) didn't work and the error wasn't
logged.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index 15d81ad..393515b 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -789,7 +789,7 @@ static int dlm_request_all_locks(struct dlm_ctxt *dlm, u8 request_from,
 				 u8 dead_node)
 {
 	struct dlm_lock_request lr;
-	enum dlm_status ret;
+	int ret;
 
 	mlog(0, "\n");
 
@@ -802,7 +802,6 @@ static int dlm_request_all_locks(struct dlm_ctxt *dlm, u8 request_from,
 	lr.dead_node = dead_node;
 
 	// send message
-	ret = DLM_NOLOCKMGR;
 	ret = o2net_send_message(DLM_LOCK_REQUEST_MSG, dlm->key,
 				 &lr, sizeof(lr), request_from, NULL);
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-10-02  8:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-02  8:29 [patch] ocfs2/dlm: small signedness bug in dlm_request_all_locks() Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox