[target:queue 47/51] drivers/target/target_core_pscsi.c:464:5: sparse: symbol 'pscsi_configure_devic

[target:queue 47/51] drivers/target/target_core_pscsi.c:464:5: sparse: symbol 'pscsi_configure_devic

[Fengguang Wu]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

Hi Nicholas, Christoph,

FYI, there are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git queue
head:   738b86ac5e56c645aa5b7bf49cb38e2a04c665f8
commit: 410aeee637c47bcf7e8dd7893347fe0811e07ab1 [47/51] target: kill struct se_subsystem_dev


vim +464 drivers/target/target_core_pscsi.c

410aeee6 Christoph Hellwig  2012-10-08 @464  int pscsi_configure_device(struct se_device *dev)
c66ac9db Nicholas Bellinger 2010-12-17  465  {
410aeee6 Christoph Hellwig  2012-10-08  466  	struct se_hba *hba = dev->se_hba;
410aeee6 Christoph Hellwig  2012-10-08  467  	struct pscsi_dev_virt *pdv = PSCSI_DEV(dev);
c66ac9db Nicholas Bellinger 2010-12-17  468  	struct scsi_device *sd;
410aeee6 Christoph Hellwig  2012-10-08  469  	struct pscsi_hba_virt *phv = dev->se_hba->hba_ptr;
c66ac9db Nicholas Bellinger 2010-12-17  470  	struct Scsi_Host *sh = phv->phv_lld_host;
c66ac9db Nicholas Bellinger 2010-12-17  471  	int legacy_mode_enable = 0;
410aeee6 Christoph Hellwig  2012-10-08  472  	int ret;

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

[-- Attachment #2: make-it-static-410aeee.diff --]
[-- Type: text/x-diff, Size: 993 bytes --]

diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index b296508..a30af59 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -461,7 +461,7 @@ static int pscsi_create_type_other(struct se_device *dev,
 	return 0;
 }
 
-int pscsi_configure_device(struct se_device *dev)
+static int pscsi_configure_device(struct se_device *dev)
 {
 	struct se_hba *hba = dev->se_hba;
 	struct pscsi_dev_virt *pdv = PSCSI_DEV(dev);
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index bcbf035..5145633 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -297,7 +297,7 @@ void transport_register_session(
 }
 EXPORT_SYMBOL(transport_register_session);
 
-void target_release_session(struct kref *kref)
+static void target_release_session(struct kref *kref)
 {
 	struct se_session *se_sess = container_of(kref,
 			struct se_session, sess_kref);

Re: [target:queue 47/51] drivers/target/target_core_pscsi.c:464:5: sparse: symbol 'pscsi_configure_d

[Nicholas A. Bellinger]

On Wed, 2012-10-10 at 07:30 +0800, Fengguang Wu wrote:
> Hi Nicholas, Christoph,
> 
> FYI, there are new sparse warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git queue
> head:   738b86ac5e56c645aa5b7bf49cb38e2a04c665f8
> commit: 410aeee637c47bcf7e8dd7893347fe0811e07ab1 [47/51] target: kill struct se_subsystem_dev
> 
> 
> vim +464 drivers/target/target_core_pscsi.c
> 
> 410aeee6 Christoph Hellwig  2012-10-08 @464  int pscsi_configure_device(struct se_device *dev)
> c66ac9db Nicholas Bellinger 2010-12-17  465  {
> 410aeee6 Christoph Hellwig  2012-10-08  466  	struct se_hba *hba = dev->se_hba;
> 410aeee6 Christoph Hellwig  2012-10-08  467  	struct pscsi_dev_virt *pdv = PSCSI_DEV(dev);
> c66ac9db Nicholas Bellinger 2010-12-17  468  	struct scsi_device *sd;
> 410aeee6 Christoph Hellwig  2012-10-08  469  	struct pscsi_hba_virt *phv = dev->se_hba->hba_ptr;
> c66ac9db Nicholas Bellinger 2010-12-17  470  	struct Scsi_Host *sh = phv->phv_lld_host;
> c66ac9db Nicholas Bellinger 2010-12-17  471  	int legacy_mode_enable = 0;
> 410aeee6 Christoph Hellwig  2012-10-08  472  	int ret;
> 
> Please consider folding the attached diff :-)
> 

Applied to target-pending/queue for v3.8-rc code.

Thanks Wu !

> ---
> 0-DAY kernel build testing backend         Open Source Technology Center
> Fengguang Wu, Yuanhan Liu                              Intel Corporation