From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: VMCI: guest side driver implementation.
Date: Thu, 10 Jan 2013 19:32:07 +0000 [thread overview]
Message-ID: <20130110193207.GA17997@elgon.mountain> (raw)
Hello George Zhang,
The patch 1f166439917b: "VMCI: guest side driver implementation."
from Jan 8, 2013, leads to the following warning:
drivers/misc/vmw_vmci/vmci_guest.c:89 vmci_get_vm_context_id()
warn: always true condition '(result >= 0) => (0-u32max >= 0)'
drivers/misc/vmw_vmci/vmci_guest.c
78 u32 vmci_get_vm_context_id(void)
79 {
80 if (vm_context_id = VMCI_INVALID_ID) {
81 u32 result;
82 struct vmci_datagram get_cid_msg;
83 get_cid_msg.dst 84 vmci_make_handle(VMCI_HYPERVISOR_CONTEXT_ID,
85 VMCI_GET_CONTEXT_ID);
86 get_cid_msg.src = VMCI_ANON_SRC_HANDLE;
87 get_cid_msg.payload_size = 0;
88 result = vmci_send_datagram(&get_cid_msg);
89 if (result >= 0)
^^^^^^^^^^^
Always true because result is an unsigned int.
90 vm_context_id = result;
regards,
dan carpenter
next reply other threads:[~2013-01-10 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 19:32 Dan Carpenter [this message]
2013-01-10 19:34 ` VMCI: guest side driver implementation George Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110193207.GA17997@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox