* re: VMCI: guest side driver implementation.
@ 2013-01-10 19:32 Dan Carpenter
2013-01-10 19:34 ` George Zhang
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-01-10 19:32 UTC (permalink / raw)
To: kernel-janitors
Hello George Zhang,
The patch 1f166439917b: "VMCI: guest side driver implementation."
from Jan 8, 2013, leads to the following warning:
drivers/misc/vmw_vmci/vmci_guest.c:89 vmci_get_vm_context_id()
warn: always true condition '(result >= 0) => (0-u32max >= 0)'
drivers/misc/vmw_vmci/vmci_guest.c
78 u32 vmci_get_vm_context_id(void)
79 {
80 if (vm_context_id = VMCI_INVALID_ID) {
81 u32 result;
82 struct vmci_datagram get_cid_msg;
83 get_cid_msg.dst 84 vmci_make_handle(VMCI_HYPERVISOR_CONTEXT_ID,
85 VMCI_GET_CONTEXT_ID);
86 get_cid_msg.src = VMCI_ANON_SRC_HANDLE;
87 get_cid_msg.payload_size = 0;
88 result = vmci_send_datagram(&get_cid_msg);
89 if (result >= 0)
^^^^^^^^^^^
Always true because result is an unsigned int.
90 vm_context_id = result;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: VMCI: guest side driver implementation.
2013-01-10 19:32 VMCI: guest side driver implementation Dan Carpenter
@ 2013-01-10 19:34 ` George Zhang
0 siblings, 0 replies; 2+ messages in thread
From: George Zhang @ 2013-01-10 19:34 UTC (permalink / raw)
To: kernel-janitors
Dan,
Thanks for this quick catch. We will fix it,
George
----- Original Message -----
> From: "Dan Carpenter" <dan.carpenter@oracle.com>
> To: georgezhang@vmware.com
> Cc: kernel-janitors@vger.kernel.org, kbuild@01.org
> Sent: Thursday, January 10, 2013 11:32:07 AM
> Subject: re: VMCI: guest side driver implementation.
>
> Hello George Zhang,
>
> The patch 1f166439917b: "VMCI: guest side driver implementation."
> from Jan 8, 2013, leads to the following warning:
> drivers/misc/vmw_vmci/vmci_guest.c:89 vmci_get_vm_context_id()
> warn: always true condition '(result >= 0) => (0-u32max >= 0)'
>
> drivers/misc/vmw_vmci/vmci_guest.c
> 78 u32 vmci_get_vm_context_id(void)
> 79 {
> 80 if (vm_context_id = VMCI_INVALID_ID) {
> 81 u32 result;
> 82 struct vmci_datagram get_cid_msg;
> 83 get_cid_msg.dst > 84
> vmci_make_handle(VMCI_HYPERVISOR_CONTEXT_ID,
> 85 VMCI_GET_CONTEXT_ID);
> 86 get_cid_msg.src = VMCI_ANON_SRC_HANDLE;
> 87 get_cid_msg.payload_size = 0;
> 88 result = vmci_send_datagram(&get_cid_msg);
> 89 if (result >= 0)
> ^^^^^^^^^^^
> Always true because result is an unsigned int.
>
> 90 vm_context_id = result;
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-10 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 19:32 VMCI: guest side driver implementation Dan Carpenter
2013-01-10 19:34 ` George Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox