* [patch] lp8727_charger: small cleanup in naming
@ 2013-01-25 15:43 Dan Carpenter
2013-01-28 13:56 ` Kim, Milo
2013-02-03 3:34 ` Anton Vorontsov
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-01-25 15:43 UTC (permalink / raw)
To: kernel-janitors
"pdata" and "pchg->pdata" are the same. Changing the function call to
pdata->get_batt_present() makes it match the check and it's a little
cleaner.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c
index 4ee71a9..5ef41b8 100644
--- a/drivers/power/lp8727_charger.c
+++ b/drivers/power/lp8727_charger.c
@@ -367,28 +367,28 @@ static int lp8727_battery_get_property(struct power_supply *psy,
return -EINVAL;
if (pdata->get_batt_present)
- val->intval = pchg->pdata->get_batt_present();
+ val->intval = pdata->get_batt_present();
break;
case POWER_SUPPLY_PROP_VOLTAGE_NOW:
if (!pdata)
return -EINVAL;
if (pdata->get_batt_level)
- val->intval = pchg->pdata->get_batt_level();
+ val->intval = pdata->get_batt_level();
break;
case POWER_SUPPLY_PROP_CAPACITY:
if (!pdata)
return -EINVAL;
if (pdata->get_batt_capacity)
- val->intval = pchg->pdata->get_batt_capacity();
+ val->intval = pdata->get_batt_capacity();
break;
case POWER_SUPPLY_PROP_TEMP:
if (!pdata)
return -EINVAL;
if (pdata->get_batt_temp)
- val->intval = pchg->pdata->get_batt_temp();
+ val->intval = pdata->get_batt_temp();
break;
default:
break;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [patch] lp8727_charger: small cleanup in naming
2013-01-25 15:43 [patch] lp8727_charger: small cleanup in naming Dan Carpenter
@ 2013-01-28 13:56 ` Kim, Milo
2013-02-03 3:34 ` Anton Vorontsov
1 sibling, 0 replies; 3+ messages in thread
From: Kim, Milo @ 2013-01-28 13:56 UTC (permalink / raw)
To: kernel-janitors
> "pdata" and "pchg->pdata" are the same. Changing the function call to
> pdata->get_batt_present() makes it match the check and it's a little
> cleaner.
Thanks!
Acked-by: Milo Kim <milo.kim@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] lp8727_charger: small cleanup in naming
2013-01-25 15:43 [patch] lp8727_charger: small cleanup in naming Dan Carpenter
2013-01-28 13:56 ` Kim, Milo
@ 2013-02-03 3:34 ` Anton Vorontsov
1 sibling, 0 replies; 3+ messages in thread
From: Anton Vorontsov @ 2013-02-03 3:34 UTC (permalink / raw)
To: kernel-janitors
On Mon, Jan 28, 2013 at 01:56:13PM +0000, Kim, Milo wrote:
> > "pdata" and "pchg->pdata" are the same. Changing the function call to
> > pdata->get_batt_present() makes it match the check and it's a little
> > cleaner.
>
> Thanks!
>
> Acked-by: Milo Kim <milo.kim@ti.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-03 3:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-25 15:43 [patch] lp8727_charger: small cleanup in naming Dan Carpenter
2013-01-28 13:56 ` Kim, Milo
2013-02-03 3:34 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox