* [patch] Staging: dwc2: remove a kfree(NULL)
@ 2013-03-15 6:03 Dan Carpenter
2013-03-15 18:18 ` Paul Zimmerman
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-03-15 6:03 UTC (permalink / raw)
To: kernel-janitors
dwc2_hcd_release() calls dwc2_hcd_free() which frees ->core_params
and sets it to NULL.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
index cdb142d..e123f1e 100644
--- a/drivers/staging/dwc2/hcd.c
+++ b/drivers/staging/dwc2/hcd.c
@@ -2939,7 +2939,6 @@ void dwc2_hcd_remove(struct device *dev, struct dwc2_hsotg *hsotg)
usb_remove_hcd(hcd);
hsotg->priv = NULL;
dwc2_hcd_release(hsotg);
- kfree(hsotg->core_params);
#ifdef CONFIG_USB_DWC2_TRACK_MISSED_SOFS
kfree(hsotg->last_frame_num_array);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [patch] Staging: dwc2: remove a kfree(NULL)
2013-03-15 6:03 [patch] Staging: dwc2: remove a kfree(NULL) Dan Carpenter
@ 2013-03-15 18:18 ` Paul Zimmerman
0 siblings, 0 replies; 2+ messages in thread
From: Paul Zimmerman @ 2013-03-15 18:18 UTC (permalink / raw)
To: kernel-janitors
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Thursday, March 14, 2013 11:04 PM
>
> dwc2_hcd_release() calls dwc2_hcd_free() which frees ->core_params
> and sets it to NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
> index cdb142d..e123f1e 100644
> --- a/drivers/staging/dwc2/hcd.c
> +++ b/drivers/staging/dwc2/hcd.c
> @@ -2939,7 +2939,6 @@ void dwc2_hcd_remove(struct device *dev, struct dwc2_hsotg *hsotg)
> usb_remove_hcd(hcd);
> hsotg->priv = NULL;
> dwc2_hcd_release(hsotg);
> - kfree(hsotg->core_params);
>
> #ifdef CONFIG_USB_DWC2_TRACK_MISSED_SOFS
> kfree(hsotg->last_frame_num_array);
Acked-by: Paul Zimmerman <paulz@synopsys.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-15 18:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-15 6:03 [patch] Staging: dwc2: remove a kfree(NULL) Dan Carpenter
2013-03-15 18:18 ` Paul Zimmerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox