* [patch] staging: slicoss: information leak in ETHTOOL_GSET
@ 2013-04-04 6:29 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-04-04 6:29 UTC (permalink / raw)
To: kernel-janitors
There are some fields in "edata" which have not been cleared. One
example is edata.cmd. It leaks uninitialized stack information to the
user.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index c8375a2..e4b8277 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -3149,6 +3149,7 @@ static int slic_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
return -EFAULT;
if (ecmd.cmd = ETHTOOL_GSET) {
+ memset(&edata, 0, sizeof(edata));
edata.supported = (SUPPORTED_10baseT_Half |
SUPPORTED_10baseT_Full |
SUPPORTED_100baseT_Half |
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-04-04 6:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-04 6:29 [patch] staging: slicoss: information leak in ETHTOOL_GSET Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox