* [patch] atmel: printing bogus information
@ 2013-04-30 7:57 Dan Carpenter
2013-05-02 16:47 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-04-30 7:57 UTC (permalink / raw)
To: Simon Kelley, David Howells
Cc: John W. Linville, linux-wireless, kernel-janitors
There was an extra ';' character added to the end of the if statement
which means that it always prints that the /proc entry wasn't created
even though it was.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/atmel.c b/drivers/net/wireless/atmel.c
index 23a3498..2876b90 100644
--- a/drivers/net/wireless/atmel.c
+++ b/drivers/net/wireless/atmel.c
@@ -1624,7 +1624,7 @@ struct net_device *init_atmel_card(unsigned short irq, unsigned long port,
netif_carrier_off(dev);
- if (!proc_create_data("driver/atmel", 0, NULL, &atmel_proc_fops, priv));
+ if (!proc_create_data("driver/atmel", 0, NULL, &atmel_proc_fops, priv))
printk(KERN_WARNING "atmel: unable to create /proc entry.\n");
printk(KERN_INFO "%s: Atmel at76c50x. Version %d.%d. MAC %pM\n",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] atmel: printing bogus information
2013-04-30 7:57 [patch] atmel: printing bogus information Dan Carpenter
@ 2013-05-02 16:47 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2013-05-02 16:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: dhowells, Simon Kelley, John W. Linville, linux-wireless,
kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There was an extra ';' character added to the end of the if statement
> which means that it always prints that the /proc entry wasn't created
> even though it was.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
The patches have gone upstream, so send it Linuswards.
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-02 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-30 7:57 [patch] atmel: printing bogus information Dan Carpenter
2013-05-02 16:47 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox