* [patch] ASoC: wm8994: missing break in wm8994_get_fll_config()
@ 2013-05-15 7:09 Dan Carpenter
2013-05-18 11:26 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-05-15 7:09 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, Takashi Iwai, patches, kernel-janitors, Liam Girdwood
Smatch complains that:
sound/soc/codecs/wm8994.c:2087 wm8994_get_fll_config()
warn: missing break? reassigning 'fll->k'
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index 9f32dd8..303d755 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -2080,6 +2080,7 @@ static int wm8994_get_fll_config(struct wm8994 *control, struct fll_div *fll,
fll->k = K / 10;
pr_debug("N=%x K=%x\n", fll->n, fll->k);
+ break;
default:
gcd_fll = gcd(freq_out, freq_in);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] ASoC: wm8994: missing break in wm8994_get_fll_config()
2013-05-15 7:09 [patch] ASoC: wm8994: missing break in wm8994_get_fll_config() Dan Carpenter
@ 2013-05-18 11:26 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-05-18 11:26 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Takashi Iwai, patches, kernel-janitors, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
On Wed, May 15, 2013 at 10:09:43AM +0300, Dan Carpenter wrote:
> Smatch complains that:
>
> sound/soc/codecs/wm8994.c:2087 wm8994_get_fll_config()
> warn: missing break? reassigning 'fll->k'
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-18 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 7:09 [patch] ASoC: wm8994: missing break in wm8994_get_fll_config() Dan Carpenter
2013-05-18 11:26 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox