* [PATCH 3/3] spi: spi-txx9: Fix warning by including linux/gpio.h
@ 2013-07-30 17:35 Emil Goode
2013-07-30 20:48 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Emil Goode @ 2013-07-30 17:35 UTC (permalink / raw)
To: kernel-janitors
According to the following commit direct inclusion of asm/gpio.h
is deprecated.
7563bbf89d065a2c3f05059ecbcc805645edcc62
("gpiolib/arches: Centralise bolierplate asm/gpio.h")
This patch fixes the below warnings by including linux/gpio.h.
arch/x86/include/asm/gpio.h:2:2: warning:
Include linux/gpio.h instead of asm/gpio.h
In file included from drivers/spi/spi-txx9.c:29:0:
arch/x86/include/asm/gpio.h:2:2: warning:
#warning Include linux/gpio.h instead of asm/gpio.h [-Wcpp]
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/spi/spi-txx9.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-txx9.c b/drivers/spi/spi-txx9.c
index e9b7681..7c6d157 100644
--- a/drivers/spi/spi-txx9.c
+++ b/drivers/spi/spi-txx9.c
@@ -26,7 +26,7 @@
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/module.h>
-#include <asm/gpio.h>
+#include <linux/gpio.h>
#define SPI_FIFO_SIZE 4
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] spi: spi-txx9: Fix warning by including linux/gpio.h
2013-07-30 17:35 [PATCH 3/3] spi: spi-txx9: Fix warning by including linux/gpio.h Emil Goode
@ 2013-07-30 20:48 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-07-30 20:48 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
On Tue, Jul 30, 2013 at 07:35:37PM +0200, Emil Goode wrote:
> According to the following commit direct inclusion of asm/gpio.h
> is deprecated.
> 7563bbf89d065a2c3f05059ecbcc805645edcc62
> ("gpiolib/arches: Centralise bolierplate asm/gpio.h")
This is already fixed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-30 20:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-30 17:35 [PATCH 3/3] spi: spi-txx9: Fix warning by including linux/gpio.h Emil Goode
2013-07-30 20:48 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox