* [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue
@ 2013-07-31 17:49 Kumar Gaurav
2013-07-31 20:26 ` Julia Lawall
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Kumar Gaurav @ 2013-07-31 17:49 UTC (permalink / raw)
To: kernel-janitors
Fixed String splitted into multiple line issue using macro
Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
---
drivers/staging/usbip/stub_dev.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index 83d629a..3b881e1 100644
--- a/drivers/staging/usbip/stub_dev.c
+++ b/drivers/staging/usbip/stub_dev.c
@@ -30,6 +30,8 @@
* In most cases, wildcard matching will be okay because driver binding can be
* changed dynamically by a userland program.
*/
+#define USBIP_REG_INTF "register new interface (bus %u dev %u ifn %u)\n"
+#define USBIP_REG_DEV "register new device (bus %u dev %u ifn %u)\n"
static struct usb_device_id stub_table[] = {
#if 0
/* just an example */
@@ -357,8 +359,9 @@ static int stub_probe(struct usb_interface *interface,
busid_priv = get_busid_priv(udev_busid);
if (!busid_priv || (busid_priv->status = STUB_BUSID_REMOV) ||
(busid_priv->status = STUB_BUSID_OTHER)) {
- dev_info(&interface->dev, "%s is not in match_busid table... "
- "skip!\n", udev_busid);
+ dev_info(&interface->dev,
+ "%s is not in match_busid table... skip!\n",
+ udev_busid);
/*
* Return value should be ENODEV or ENOXIO to continue trying
@@ -386,8 +389,7 @@ static int stub_probe(struct usb_interface *interface,
return -ENODEV;
busid_priv->interf_count++;
- dev_info(&interface->dev, "usbip-host: register new interface "
- "(bus %u dev %u ifn %u)\n",
+ dev_info(&interface->dev, USBIP_REG_INTF,
udev->bus->busnum, udev->devnum,
interface->cur_altsetting->desc.bInterfaceNumber);
@@ -412,8 +414,8 @@ static int stub_probe(struct usb_interface *interface,
if (!sdev)
return -ENOMEM;
- dev_info(&interface->dev, "usbip-host: register new device "
- "(bus %u dev %u ifn %u)\n", udev->bus->busnum, udev->devnum,
+ dev_info(&interface->dev, USBIP_REG_DEV,
+ udev->bus->busnum, udev->devnum,
interface->cur_altsetting->desc.bInterfaceNumber);
busid_priv->interf_count = 0;
@@ -426,7 +428,8 @@ static int stub_probe(struct usb_interface *interface,
err = stub_add_files(&interface->dev);
if (err) {
- dev_err(&interface->dev, "stub_add_files for %s\n", udev_busid);
+ dev_err(&interface->dev, "stub_add_files for %s\n",
+ udev_busid);
usb_set_intfdata(interface, NULL);
usb_put_intf(interface);
usb_put_dev(udev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue
2013-07-31 17:49 [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue Kumar Gaurav
@ 2013-07-31 20:26 ` Julia Lawall
2013-08-01 7:17 ` Dan Carpenter
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2013-07-31 20:26 UTC (permalink / raw)
To: kernel-janitors
On Wed, 31 Jul 2013, Kumar Gaurav wrote:
> Fixed String splitted into multiple line issue using macro
I'm not an expert on this kind of style issue, but I prefer strings that
look like strings.
julia
> Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
> ---
> drivers/staging/usbip/stub_dev.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
> index 83d629a..3b881e1 100644
> --- a/drivers/staging/usbip/stub_dev.c
> +++ b/drivers/staging/usbip/stub_dev.c
> @@ -30,6 +30,8 @@
> * In most cases, wildcard matching will be okay because driver binding can be
> * changed dynamically by a userland program.
> */
> +#define USBIP_REG_INTF "register new interface (bus %u dev %u ifn %u)\n"
> +#define USBIP_REG_DEV "register new device (bus %u dev %u ifn %u)\n"
> static struct usb_device_id stub_table[] = {
> #if 0
> /* just an example */
> @@ -357,8 +359,9 @@ static int stub_probe(struct usb_interface *interface,
> busid_priv = get_busid_priv(udev_busid);
> if (!busid_priv || (busid_priv->status = STUB_BUSID_REMOV) ||
> (busid_priv->status = STUB_BUSID_OTHER)) {
> - dev_info(&interface->dev, "%s is not in match_busid table... "
> - "skip!\n", udev_busid);
> + dev_info(&interface->dev,
> + "%s is not in match_busid table... skip!\n",
> + udev_busid);
>
> /*
> * Return value should be ENODEV or ENOXIO to continue trying
> @@ -386,8 +389,7 @@ static int stub_probe(struct usb_interface *interface,
> return -ENODEV;
>
> busid_priv->interf_count++;
> - dev_info(&interface->dev, "usbip-host: register new interface "
> - "(bus %u dev %u ifn %u)\n",
> + dev_info(&interface->dev, USBIP_REG_INTF,
> udev->bus->busnum, udev->devnum,
> interface->cur_altsetting->desc.bInterfaceNumber);
>
> @@ -412,8 +414,8 @@ static int stub_probe(struct usb_interface *interface,
> if (!sdev)
> return -ENOMEM;
>
> - dev_info(&interface->dev, "usbip-host: register new device "
> - "(bus %u dev %u ifn %u)\n", udev->bus->busnum, udev->devnum,
> + dev_info(&interface->dev, USBIP_REG_DEV,
> + udev->bus->busnum, udev->devnum,
> interface->cur_altsetting->desc.bInterfaceNumber);
>
> busid_priv->interf_count = 0;
> @@ -426,7 +428,8 @@ static int stub_probe(struct usb_interface *interface,
>
> err = stub_add_files(&interface->dev);
> if (err) {
> - dev_err(&interface->dev, "stub_add_files for %s\n", udev_busid);
> + dev_err(&interface->dev, "stub_add_files for %s\n",
> + udev_busid);
> usb_set_intfdata(interface, NULL);
> usb_put_intf(interface);
> usb_put_dev(udev);
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue
2013-07-31 17:49 [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue Kumar Gaurav
2013-07-31 20:26 ` Julia Lawall
@ 2013-08-01 7:17 ` Dan Carpenter
2013-08-02 2:40 ` Kumar Gaurav
2013-08-02 5:57 ` Julia Lawall
3 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2013-08-01 7:17 UTC (permalink / raw)
To: kernel-janitors
On Wed, Jul 31, 2013 at 10:26:15PM +0200, Julia Lawall wrote:
> On Wed, 31 Jul 2013, Kumar Gaurav wrote:
>
> > Fixed String splitted into multiple line issue using macro
>
> I'm not an expert on this kind of style issue, but I prefer strings that
> look like strings.
>
Yeah. This patch makes the code more abstract and harder to
understand.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue
2013-07-31 17:49 [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue Kumar Gaurav
2013-07-31 20:26 ` Julia Lawall
2013-08-01 7:17 ` Dan Carpenter
@ 2013-08-02 2:40 ` Kumar Gaurav
2013-08-02 5:57 ` Julia Lawall
3 siblings, 0 replies; 5+ messages in thread
From: Kumar Gaurav @ 2013-08-02 2:40 UTC (permalink / raw)
To: kernel-janitors
On Thursday 01 August 2013 10:27 AM, Jiany Wu wrote:
> I have the same idea with julia.
> It is more difficult to check the log if we use MACRO instead of the
> strings.
> If we search in the system log, according to the string, we will find
> out the macro first. later we also need to find out where the macro is
> using.
>
>
> 2013/8/1 Julia Lawall <julia.lawall@lip6.fr <mailto:julia.lawall@lip6.fr>>
>
> On Wed, 31 Jul 2013, Kumar Gaurav wrote:
>
> > Fixed String splitted into multiple line issue using macro
>
> I'm not an expert on this kind of style issue, but I prefer
> strings that
> look like strings.
>
> julia
>
> > Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com
> <mailto:kumargauravgupta3@gmail.com>>
> > ---
> > drivers/staging/usbip/stub_dev.c | 17 ++++++++++-------
> > 1 file changed, 10 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/staging/usbip/stub_dev.c
> b/drivers/staging/usbip/stub_dev.c
> > index 83d629a..3b881e1 100644
> > --- a/drivers/staging/usbip/stub_dev.c
> > +++ b/drivers/staging/usbip/stub_dev.c
> > @@ -30,6 +30,8 @@
> > * In most cases, wildcard matching will be okay because driver
> binding can be
> > * changed dynamically by a userland program.
> > */
> > +#define USBIP_REG_INTF "register new interface (bus %u dev %u
> ifn %u)\n"
> > +#define USBIP_REG_DEV "register new device (bus %u dev %u ifn
> %u)\n"
> > static struct usb_device_id stub_table[] = {
> > #if 0
> > /* just an example */
> > @@ -357,8 +359,9 @@ static int stub_probe(struct usb_interface
> *interface,
> > busid_priv = get_busid_priv(udev_busid);
> > if (!busid_priv || (busid_priv->status = STUB_BUSID_REMOV) ||
> > (busid_priv->status = STUB_BUSID_OTHER)) {
> > - dev_info(&interface->dev, "%s is not in
> match_busid table... "
> > - "skip!\n", udev_busid);
> > + dev_info(&interface->dev,
> > + "%s is not in match_busid table... skip!\n",
> > + udev_busid);
> >
> > /*
> > * Return value should be ENODEV or ENOXIO to
> continue trying
> > @@ -386,8 +389,7 @@ static int stub_probe(struct usb_interface
> *interface,
> > return -ENODEV;
> >
> > busid_priv->interf_count++;
> > - dev_info(&interface->dev, "usbip-host: register
> new interface "
> > - "(bus %u dev %u ifn %u)\n",
> > + dev_info(&interface->dev, USBIP_REG_INTF,
> > udev->bus->busnum, udev->devnum,
> > interface->cur_altsetting->desc.bInterfaceNumber);
> >
> > @@ -412,8 +414,8 @@ static int stub_probe(struct usb_interface
> *interface,
> > if (!sdev)
> > return -ENOMEM;
> >
> > - dev_info(&interface->dev, "usbip-host: register new device "
> > - "(bus %u dev %u ifn %u)\n", udev->bus->busnum,
> udev->devnum,
> > + dev_info(&interface->dev, USBIP_REG_DEV,
> > + udev->bus->busnum, udev->devnum,
> > interface->cur_altsetting->desc.bInterfaceNumber);
> >
> > busid_priv->interf_count = 0;
> > @@ -426,7 +428,8 @@ static int stub_probe(struct usb_interface
> *interface,
> >
> > err = stub_add_files(&interface->dev);
> > if (err) {
> > - dev_err(&interface->dev, "stub_add_files for
> %s\n", udev_busid);
> > + dev_err(&interface->dev, "stub_add_files for %s\n",
> > + udev_busid);
> > usb_set_intfdata(interface, NULL);
> > usb_put_intf(interface);
> > usb_put_dev(udev);
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> kernel-janitors" in
> > the body of a message to majordomo@vger.kernel.org
> <mailto:majordomo@vger.kernel.org>
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe
> kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> <mailto:majordomo@vger.kernel.org>
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
Thanks you all for suggestions. I'll try finding some other way.
Regargs
Kumar Gaurav
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue
2013-07-31 17:49 [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue Kumar Gaurav
` (2 preceding siblings ...)
2013-08-02 2:40 ` Kumar Gaurav
@ 2013-08-02 5:57 ` Julia Lawall
3 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2013-08-02 5:57 UTC (permalink / raw)
To: kernel-janitors
> Thanks you all for suggestions. I'll try finding some other way.
If the strings don't fit, you can just go over 80 characters.
julia
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-02 5:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31 17:49 [PATCH] USBIP:stub_dev.c fixing string splitted into multiple line issue Kumar Gaurav
2013-07-31 20:26 ` Julia Lawall
2013-08-01 7:17 ` Dan Carpenter
2013-08-02 2:40 ` Kumar Gaurav
2013-08-02 5:57 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox