* Re: [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon
2013-08-04 3:41 [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon Kumar Gaurav
@ 2013-08-04 16:48 ` Dan Carpenter
2013-08-04 17:59 ` kumargauravgupta3
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2013-08-04 16:48 UTC (permalink / raw)
To: kernel-janitors
Yes yes... This applies fine. Send it to the people...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon
2013-08-04 3:41 [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon Kumar Gaurav
2013-08-04 16:48 ` Dan Carpenter
@ 2013-08-04 17:59 ` kumargauravgupta3
2013-08-04 18:08 ` Dan Carpenter
2013-08-04 18:53 ` Kumar Gaurav
2013-08-04 18:56 ` Kumar Gaurav
3 siblings, 1 reply; 7+ messages in thread
From: kumargauravgupta3 @ 2013-08-04 17:59 UTC (permalink / raw)
To: arnaud.patard, gregkh, aaro.koskinen, dan.carpenter
Cc: linux-kernel, kernel-janitors
From: Kumar Gaurav <kumar@AnandLinux.(none)>
diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h
index 2c0a31c..679a822 100644
--- a/drivers/staging/xgifb/vb_setmode.h
+++ b/drivers/staging/xgifb/vb_setmode.h
@@ -13,7 +13,7 @@ extern void XGI_GetVBType(struct vb_device_info *);
extern void XGI_SenseCRT1(struct vb_device_info *);
extern unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
struct xgi_hw_device_info *HwDeviceExtension,
- unsigned short ModeNo) ;
+ unsigned short ModeNo);
extern unsigned char XGI_SearchModeID(unsigned short ModeNo,
unsigned short *ModeIdIndex,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon
2013-08-04 17:59 ` kumargauravgupta3
@ 2013-08-04 18:08 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2013-08-04 18:08 UTC (permalink / raw)
To: kumargauravgupta3
Cc: arnaud.patard, gregkh, aaro.koskinen, linux-kernel,
kernel-janitors
On Sun, Aug 04, 2013 at 11:28:21PM +0530, kumargauravgupta3@gmail.com wrote:
> From: Kumar Gaurav <kumar@AnandLinux.(none)>
Gar... Sorry, when you sent this to kj earlier, I should have
pointed out that there is no Signed-off-by line and the From line
is not correct or needed.
Signed-off-by is intended like a signing a legal document, it should
match the email you are using to send the patch.
My bad. Can you resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon
2013-08-04 3:41 [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon Kumar Gaurav
2013-08-04 16:48 ` Dan Carpenter
2013-08-04 17:59 ` kumargauravgupta3
@ 2013-08-04 18:53 ` Kumar Gaurav
2013-08-04 18:56 ` Aaro Koskinen
2013-08-04 18:56 ` Kumar Gaurav
3 siblings, 1 reply; 7+ messages in thread
From: Kumar Gaurav @ 2013-08-04 18:53 UTC (permalink / raw)
To: arnaud.patard, gregkh, aaro.koskinen, dan.carpenter
Cc: linux-kernel, kernel-janitors, Kumar Gaurav
Fixed issue by removing Space before semicolon
Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
---
drivers/staging/xgifb/vb_setmode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h
index 2c0a31c..679a822 100644
--- a/drivers/staging/xgifb/vb_setmode.h
+++ b/drivers/staging/xgifb/vb_setmode.h
@@ -13,7 +13,7 @@ extern void XGI_GetVBType(struct vb_device_info *);
extern void XGI_SenseCRT1(struct vb_device_info *);
extern unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
struct xgi_hw_device_info *HwDeviceExtension,
- unsigned short ModeNo) ;
+ unsigned short ModeNo);
extern unsigned char XGI_SearchModeID(unsigned short ModeNo,
unsigned short *ModeIdIndex,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon
2013-08-04 18:53 ` Kumar Gaurav
@ 2013-08-04 18:56 ` Aaro Koskinen
0 siblings, 0 replies; 7+ messages in thread
From: Aaro Koskinen @ 2013-08-04 18:56 UTC (permalink / raw)
To: Kumar Gaurav
Cc: arnaud.patard, gregkh, dan.carpenter, linux-kernel,
kernel-janitors
On Mon, Aug 05, 2013 at 12:11:02AM +0530, Kumar Gaurav wrote:
> Fixed issue by removing Space before semicolon
>
> Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
> ---
> drivers/staging/xgifb/vb_setmode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h
> index 2c0a31c..679a822 100644
> --- a/drivers/staging/xgifb/vb_setmode.h
> +++ b/drivers/staging/xgifb/vb_setmode.h
> @@ -13,7 +13,7 @@ extern void XGI_GetVBType(struct vb_device_info *);
> extern void XGI_SenseCRT1(struct vb_device_info *);
> extern unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
> struct xgi_hw_device_info *HwDeviceExtension,
> - unsigned short ModeNo) ;
> + unsigned short ModeNo);
There's a similar issue in vb_table.h, line 1287. Maybe fix that also
at the same time?
Thanks,
A.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon
2013-08-04 3:41 [PATCH] Staging:xgifb:Fixed a warning of Space before semicolon Kumar Gaurav
` (2 preceding siblings ...)
2013-08-04 18:53 ` Kumar Gaurav
@ 2013-08-04 18:56 ` Kumar Gaurav
3 siblings, 0 replies; 7+ messages in thread
From: Kumar Gaurav @ 2013-08-04 18:56 UTC (permalink / raw)
To: kernel-janitors
On Sunday 04 August 2013 11:38 PM, Dan Carpenter wrote:
> On Sun, Aug 04, 2013 at 11:28:21PM +0530, kumargauravgupta3@gmail.com wrote:
>> From: Kumar Gaurav <kumar@AnandLinux.(none)>
> Gar... Sorry, when you sent this to kj earlier, I should have
> pointed out that there is no Signed-off-by line and the From line
> is not correct or needed.
>
> Signed-off-by is intended like a signing a legal document, it should
> match the email you are using to send the patch.
>
> My bad. Can you resend.
>
> regards,
> dan carpenter
>
Thanks for correcting me. i sent the new one. i had put the signedoff
statement in this too but method was wrong so probably that's why it
didn't appeared in mail. I checked the next one by sending to myself and
then sent to all.
Regards
Kumar Gaurav
^ permalink raw reply [flat|nested] 7+ messages in thread