* [patch] usb: chipidea: fix a NULL dereference on error
@ 2013-08-16 7:34 Dan Carpenter
2013-08-16 9:32 ` Peter Chen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-08-16 7:34 UTC (permalink / raw)
To: kernel-janitors
The regulator_disable() function can't accept NULL pointers so we need
to add a check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
index 6f96795..abfb1cc 100644
--- a/drivers/usb/chipidea/host.c
+++ b/drivers/usb/chipidea/host.c
@@ -88,7 +88,8 @@ static int host_start(struct ci_hdrc *ci)
return ret;
disable_reg:
- regulator_disable(ci->platdata->reg_vbus);
+ if (ci->platdata->reg_vbus)
+ regulator_disable(ci->platdata->reg_vbus);
put_hcd:
usb_put_hcd(hcd);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] usb: chipidea: fix a NULL dereference on error
2013-08-16 7:34 [patch] usb: chipidea: fix a NULL dereference on error Dan Carpenter
@ 2013-08-16 9:32 ` Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2013-08-16 9:32 UTC (permalink / raw)
To: kernel-janitors
On Fri, Aug 16, 2013 at 10:34:10AM +0300, Dan Carpenter wrote:
> The regulator_disable() function can't accept NULL pointers so we need
> to add a check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
> index 6f96795..abfb1cc 100644
> --- a/drivers/usb/chipidea/host.c
> +++ b/drivers/usb/chipidea/host.c
> @@ -88,7 +88,8 @@ static int host_start(struct ci_hdrc *ci)
> return ret;
>
> disable_reg:
> - regulator_disable(ci->platdata->reg_vbus);
> + if (ci->platdata->reg_vbus)
> + regulator_disable(ci->platdata->reg_vbus);
>
> put_hcd:
> usb_put_hcd(hcd);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Acked-by: Peter Chen <peter.chen@freescale.com>
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-16 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-16 7:34 [patch] usb: chipidea: fix a NULL dereference on error Dan Carpenter
2013-08-16 9:32 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox