From: Greg KH <gregkh@linuxfoundation.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/6] drivers:usb:host:xhci.h Removing xhci_hcd from argument
Date: Fri, 16 Aug 2013 19:00:34 +0000 [thread overview]
Message-ID: <20130816190034.GE8768@kroah.com> (raw)
In-Reply-To: <1376678922-15217-1-git-send-email-kumargauravgupta3@gmail.com>
On Sat, Aug 17, 2013 at 12:18:42AM +0530, Kumar Gaurav wrote:
> Removed struct xhci_hcd from xhci_readl fucntion as it's no more in use.
> ---
> drivers/usb/host/xhci.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index c338741..7cf0e41 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1598,8 +1598,7 @@ static inline struct usb_hcd *xhci_to_hcd(struct xhci_hcd *xhci)
>
> /* TODO: copied from ehci.h - can be refactored? */
> /* xHCI spec says all registers are little endian */
> -static inline unsigned int xhci_readl(const struct xhci_hcd *xhci,
> - __le32 __iomem *regs)
> +static inline unsigned int xhci_readl(__le32 __iomem *regs)
And you broke the build :(
Sorry, that's not ok.
greg k-h
next prev parent reply other threads:[~2013-08-16 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 18:49 [PATCH 1/6] drivers:usb:host:xhci.h Removing xhci_hcd from argument Kumar Gaurav
2013-08-16 18:57 ` Greg KH
2013-08-16 19:00 ` Greg KH [this message]
2013-08-16 19:14 ` Greg KH
2013-08-16 19:16 ` Kumar Gaurav
2013-08-17 6:49 ` Julia Lawall
2013-08-17 18:21 ` Kumar Gaurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816190034.GE8768@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox