Re: [PATCH 1/6] drivers:usb:host:xhci.h Removing xhci_hcd from argument

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Aug 17, 2013 at 12:34:04AM +0530, Kumar Gaurav wrote:
> On Saturday 17 August 2013 12:30 AM, Greg KH wrote:
> >On Sat, Aug 17, 2013 at 12:18:42AM +0530, Kumar Gaurav wrote:
> >>Removed struct xhci_hcd from xhci_readl fucntion as it's no more in use.
> >>---
> >>  drivers/usb/host/xhci.h |    3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >>diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.hthe
> >>index c338741..7cf0e41 100644
> >>--- a/drivers/usb/host/xhci.h
> >>+++ b/drivers/usb/host/xhci.h
> >>@@ -1598,8 +1598,7 @@ static inline struct usb_hcd *xhci_to_hcd(struct xhci_hcd *xhci)
> >>  /* TODO: copied from ehci.h - can be refactored? */
> >>  /* xHCI spec says all registers are little endian */
> >>-static inline unsigned int xhci_readl(const struct xhci_hcd *xhci,
> >>-		__le32 __iomem *regs)
> >>+static inline unsigned int xhci_readl(__le32 __iomem *regs)
> >And you broke the build :(
> >
> >Sorry, that's not ok.
> >
> >greg k-h
> I'm writing patch to change function definition along with changes
> in program files where this function is called.
> After changing all files i built the module and it compiled as well.
> 
> There were 6 files which were using xhci_read. I fixed all the calls
> and compiled.
> Am i missing anything? Please suggest then i'll send patches again

Patches get applied in order, and each patch must be "stand alone".  In
other words, one patch can not break the build, and the next one fix it
up.  Perhaps this should all just be one big patch, as you really are
only doing one thing, right?

thanks,

greg k-h