* [patch] [media] sh_vou: almost forever loop in sh_vou_try_fmt_vid_out()
@ 2013-08-23 9:54 Dan Carpenter
2013-08-26 2:59 ` Prabhakar Lad
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-08-23 9:54 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: Mauro Carvalho Chehab, Hans Verkuil, Lad, Prabhakar,
Laurent Pinchart, linux-media, kernel-janitors
The "i < " part of the "i < ARRAY_SIZE()" condition was missing.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c
index 7a9c5e9..41f612c 100644
--- a/drivers/media/platform/sh_vou.c
+++ b/drivers/media/platform/sh_vou.c
@@ -776,9 +776,10 @@ static int sh_vou_try_fmt_vid_out(struct file *file, void *priv,
v4l_bound_align_image(&pix->width, 0, VOU_MAX_IMAGE_WIDTH, 1,
&pix->height, 0, VOU_MAX_IMAGE_HEIGHT, 1, 0);
- for (i = 0; ARRAY_SIZE(vou_fmt); i++)
+ for (i = 0; i < ARRAY_SIZE(vou_fmt); i++) {
if (vou_fmt[i].pfmt = pix->pixelformat)
return 0;
+ }
pix->pixelformat = vou_fmt[0].pfmt;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] [media] sh_vou: almost forever loop in sh_vou_try_fmt_vid_out()
2013-08-23 9:54 [patch] [media] sh_vou: almost forever loop in sh_vou_try_fmt_vid_out() Dan Carpenter
@ 2013-08-26 2:59 ` Prabhakar Lad
0 siblings, 0 replies; 2+ messages in thread
From: Prabhakar Lad @ 2013-08-26 2:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Guennadi Liakhovetski, Mauro Carvalho Chehab, Hans Verkuil,
Laurent Pinchart, linux-media, kernel-janitors
On Fri, Aug 23, 2013 at 3:24 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "i < " part of the "i < ARRAY_SIZE()" condition was missing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Lad, Prabhakar <prabhakar.lad@ti.com>
Regards,
--Prabhakar Lad
>
> diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c
> index 7a9c5e9..41f612c 100644
> --- a/drivers/media/platform/sh_vou.c
> +++ b/drivers/media/platform/sh_vou.c
> @@ -776,9 +776,10 @@ static int sh_vou_try_fmt_vid_out(struct file *file, void *priv,
> v4l_bound_align_image(&pix->width, 0, VOU_MAX_IMAGE_WIDTH, 1,
> &pix->height, 0, VOU_MAX_IMAGE_HEIGHT, 1, 0);
>
> - for (i = 0; ARRAY_SIZE(vou_fmt); i++)
> + for (i = 0; i < ARRAY_SIZE(vou_fmt); i++) {
> if (vou_fmt[i].pfmt = pix->pixelformat)
> return 0;
> + }
>
> pix->pixelformat = vou_fmt[0].pfmt;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-26 2:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23 9:54 [patch] [media] sh_vou: almost forever loop in sh_vou_try_fmt_vid_out() Dan Carpenter
2013-08-26 2:59 ` Prabhakar Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox