From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Jeff Moyer <jmoyer@redhat.com>,
Ramprasad Chinthekindi <rchinthekindi@stec-inc.com>,
Akhil Bhansali <abhansali@stec-inc.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 4/4] skd: remove unneeded NULL check
Date: Fri, 13 Sep 2013 08:06:11 +0000 [thread overview]
Message-ID: <20130913080610.GH19211@elgon.mountain> (raw)
We already dereferenced "skdev" a few lines earlier in the debug code so
my static checker complains. I audited the callers and "skdev" is never
NULL here so I have removed the check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 20ad843..827f927 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2909,7 +2909,7 @@ static void skd_do_inq_page_da(struct skd_device *skdev,
inq.page_code = DRIVER_INQ_EVPD_PAGE_CODE;
- if (skdev && skdev->pdev && skdev->pdev->bus) {
+ if (skdev->pdev && skdev->pdev->bus) {
skd_get_link_info(skdev->pdev,
&inq.pcie_link_speed, &inq.pcie_link_lanes);
inq.pcie_bus_number = cpu_to_be16(skdev->pdev->bus->number);
reply other threads:[~2013-09-13 8:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913080610.GH19211@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=abhansali@stec-inc.com \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rchinthekindi@stec-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox