* [patch 4/4] skd: remove unneeded NULL check
@ 2013-09-13 8:06 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-09-13 8:06 UTC (permalink / raw)
To: Jens Axboe
Cc: Jeff Moyer, Ramprasad Chinthekindi, Akhil Bhansali, linux-kernel,
kernel-janitors
We already dereferenced "skdev" a few lines earlier in the debug code so
my static checker complains. I audited the callers and "skdev" is never
NULL here so I have removed the check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 20ad843..827f927 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2909,7 +2909,7 @@ static void skd_do_inq_page_da(struct skd_device *skdev,
inq.page_code = DRIVER_INQ_EVPD_PAGE_CODE;
- if (skdev && skdev->pdev && skdev->pdev->bus) {
+ if (skdev->pdev && skdev->pdev->bus) {
skd_get_link_info(skdev->pdev,
&inq.pcie_link_speed, &inq.pcie_link_lanes);
inq.pcie_bus_number = cpu_to_be16(skdev->pdev->bus->number);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-09-13 8:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 8:06 [patch 4/4] skd: remove unneeded NULL check Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox