* [patch] gpio: msm: make msm_gpio.summary_irq signed for error handling
@ 2013-11-07 7:51 Dan Carpenter
2013-11-18 10:42 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-11-07 7:51 UTC (permalink / raw)
To: Linus Walleij; +Cc: Grant Likely, Rob Herring, linux-gpio, kernel-janitors
There is a bug in msm_gpio_probe() where we do:
msm_gpio.summary_irq = platform_get_irq(pdev, 0);
if (msm_gpio.summary_irq < 0) {
The problem is that "msm_gpio.summary_irq" is unsigned so the error
handling doesn't work. I've fixed it by making it signed.
Fixes: 43f68444bce7 ('gpio: msm: Add device tree and irqdomain support for gpio-msm-v2')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpio/gpio-msm-v2.c b/drivers/gpio/gpio-msm-v2.c
index f7a0cc4..7b37300 100644
--- a/drivers/gpio/gpio-msm-v2.c
+++ b/drivers/gpio/gpio-msm-v2.c
@@ -102,7 +102,7 @@ struct msm_gpio_dev {
DECLARE_BITMAP(wake_irqs, MAX_NR_GPIO);
DECLARE_BITMAP(dual_edge_irqs, MAX_NR_GPIO);
struct irq_domain *domain;
- unsigned int summary_irq;
+ int summary_irq;
void __iomem *msm_tlmm_base;
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] gpio: msm: make msm_gpio.summary_irq signed for error handling
2013-11-07 7:51 [patch] gpio: msm: make msm_gpio.summary_irq signed for error handling Dan Carpenter
@ 2013-11-18 10:42 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-11-18 10:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Grant Likely, Rob Herring, linux-gpio@vger.kernel.org,
kernel-janitors
On Thu, Nov 7, 2013 at 8:51 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There is a bug in msm_gpio_probe() where we do:
>
> msm_gpio.summary_irq = platform_get_irq(pdev, 0);
> if (msm_gpio.summary_irq < 0) {
>
> The problem is that "msm_gpio.summary_irq" is unsigned so the error
> handling doesn't work. I've fixed it by making it signed.
>
> Fixes: 43f68444bce7 ('gpio: msm: Add device tree and irqdomain support for gpio-msm-v2')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied for fixes and tagged for stable.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-18 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-07 7:51 [patch] gpio: msm: make msm_gpio.summary_irq signed for error handling Dan Carpenter
2013-11-18 10:42 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox