* [patch] pinctrl: abx500: fix some more bitwise AND tests
@ 2013-11-09 23:35 Dan Carpenter
2013-11-19 7:58 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-11-09 23:35 UTC (permalink / raw)
To: Linus Walleij, Patrice CHOTARD; +Cc: linux-kernel, kernel-janitors
I sent a patch to fix some bitwise AND tests but I guess I missed some.
Sorry about that.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
index 4780959..5183e7bb 100644
--- a/drivers/pinctrl/pinctrl-abx500.c
+++ b/drivers/pinctrl/pinctrl-abx500.c
@@ -418,7 +418,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, struct gpio_chip *chip,
ret = abx500_gpio_set_bits(chip,
AB8500_GPIO_ALTFUN_REG,
af.alt_bit1,
- !!(af.alta_val && BIT(0)));
+ !!(af.alta_val & BIT(0)));
if (ret < 0)
goto out;
@@ -439,7 +439,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, struct gpio_chip *chip,
goto out;
ret = abx500_gpio_set_bits(chip, AB8500_GPIO_ALTFUN_REG,
- af.alt_bit1, !!(af.altb_val && BIT(0)));
+ af.alt_bit1, !!(af.altb_val & BIT(0)));
if (ret < 0)
goto out;
@@ -462,7 +462,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, struct gpio_chip *chip,
goto out;
ret = abx500_gpio_set_bits(chip, AB8500_GPIO_ALTFUN_REG,
- af.alt_bit2, !!(af.altc_val && BIT(1)));
+ af.alt_bit2, !!(af.altc_val & BIT(1)));
break;
default:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] pinctrl: abx500: fix some more bitwise AND tests
2013-11-09 23:35 [patch] pinctrl: abx500: fix some more bitwise AND tests Dan Carpenter
@ 2013-11-19 7:58 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-11-19 7:58 UTC (permalink / raw)
To: Dan Carpenter
Cc: Patrice CHOTARD, linux-kernel@vger.kernel.org, kernel-janitors
On Sun, Nov 10, 2013 at 12:35 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> I sent a patch to fix some bitwise AND tests but I guess I missed some.
> Sorry about that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied for fixes, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-19 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-09 23:35 [patch] pinctrl: abx500: fix some more bitwise AND tests Dan Carpenter
2013-11-19 7:58 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox