[patch] xfs: extra semi-colon breaks a condition

[patch] xfs: extra semi-colon breaks a condition

[Dan Carpenter]

There were some extra semi-colons here which mean that we return true
unintentionally.

Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 98016b3..75df77d 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -659,10 +659,10 @@ xfs_check_page_type(
 			if (type = XFS_IO_UNWRITTEN)
 				return true;
 		} else if (buffer_delay(bh)) {
-			if (type = XFS_IO_DELALLOC);
+			if (type = XFS_IO_DELALLOC)
 				return true;
 		} else if (buffer_dirty(bh) && buffer_mapped(bh)) {
-			if (type = XFS_IO_OVERWRITE);
+			if (type = XFS_IO_OVERWRITE)
 				return true;
 		}
 

Re: [patch] xfs: extra semi-colon breaks a condition

[Brian Foster]

On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
> 
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
>  			if (type = XFS_IO_UNWRITTEN)
>  				return true;
>  		} else if (buffer_delay(bh)) {
> -			if (type = XFS_IO_DELALLOC);
> +			if (type = XFS_IO_DELALLOC)
>  				return true;
>  		} else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> -			if (type = XFS_IO_OVERWRITE);
> +			if (type = XFS_IO_OVERWRITE)
>  				return true;
>  		}
>  

Nice catch.

Reviewed-by: Brian Foster <bfoster@redhat.com>

> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

Re: [patch] xfs: extra semi-colon breaks a condition

[Eric Sandeen]

On 3/28/14, 3:03 AM, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
> 
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')

that's terrifying.

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 98016b3..75df77d 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -659,10 +659,10 @@ xfs_check_page_type(
>  			if (type = XFS_IO_UNWRITTEN)
>  				return true;
>  		} else if (buffer_delay(bh)) {
> -			if (type = XFS_IO_DELALLOC);
> +			if (type = XFS_IO_DELALLOC)
>  				return true;
>  		} else if (buffer_dirty(bh) && buffer_mapped(bh)) {
> -			if (type = XFS_IO_OVERWRITE);
> +			if (type = XFS_IO_OVERWRITE)
>  				return true;
>  		}
>  
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

Re: [patch] xfs: extra semi-colon breaks a condition

[Dave Chinner]

On Fri, Mar 28, 2014 at 11:03:13AM +0300, Dan Carpenter wrote:
> There were some extra semi-colons here which mean that we return true
> unintentionally.
> 
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Dan, $BEVVIE_OF_CHOICE is on me next time we are in the same place.
And bring a handful brown paper bags as well because there's a few
people here that need to wear them for a while. :/

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com