* [patch] RDMA/cxgb4: release mutex on error in c4iw_reject_cr()
[not found] <001f01cf4e7f$6ceba770$46c2f650$@opengridcomputing.com>
@ 2014-04-02 15:08 ` Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-04-02 15:08 UTC (permalink / raw)
To: Steve Wise
Cc: Roland Dreier, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
We recently added some locking to this function and there was an error
path which missed the unlock.
Fixes: 9306dcbc96f3 ('RDMA/cxgb4: Lock around accept/reject downcalls')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 303e29c..f3753a1 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2524,6 +2524,7 @@ int c4iw_reject_cr(struct iw_cm_id *cm_id, const void *pdata, u8 pdata_len)
mutex_lock(&ep->com.mutex);
if (ep->com.state = DEAD) {
+ mutex_unlock(&ep->com.mutex);
c4iw_put_ep(&ep->com);
return -ECONNRESET;
}
^ permalink raw reply related [flat|nested] only message in thread