* [patch] drm/panel: s6e8aa0: silence array overflow warning
@ 2014-04-09 15:21 Dan Carpenter
2014-04-10 5:48 ` Andrzej Hajda
2014-05-02 11:21 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-04-09 15:21 UTC (permalink / raw)
To: Thierry Reding, Andrzej Hajda
Cc: Grant Likely, Rob Herring, kernel-janitors, dri-devel
Smatch complains that we are reading beyond the end of the array here:
drivers/gpu/drm/panel/panel-s6e8aa0.c:852 s6e8aa0_read_mtp_id()
warn: buffer overflow 's6e8aa0_variants' 4 <= 4
We set the error code, so it's not harmful but it looks like a return
was intended here so lets add that and silence the warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Compile tested only.
diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/panel/panel-s6e8aa0.c
index 35941d2..06e57a2 100644
--- a/drivers/gpu/drm/panel/panel-s6e8aa0.c
+++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c
@@ -847,6 +847,7 @@ static void s6e8aa0_read_mtp_id(struct s6e8aa0 *ctx)
if (i >= ARRAY_SIZE(s6e8aa0_variants)) {
dev_err(ctx->dev, "unsupported display version %d\n", id[1]);
ctx->error = -EINVAL;
+ return;
}
ctx->variant = &s6e8aa0_variants[i];
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] drm/panel: s6e8aa0: silence array overflow warning
2014-04-09 15:21 [patch] drm/panel: s6e8aa0: silence array overflow warning Dan Carpenter
@ 2014-04-10 5:48 ` Andrzej Hajda
2014-05-02 11:21 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Andrzej Hajda @ 2014-04-10 5:48 UTC (permalink / raw)
To: Dan Carpenter, Thierry Reding
Cc: David Airlie, Grant Likely, Rob Herring, dri-devel,
kernel-janitors
Hi Dan,
Thanks for the patch.
On 04/09/2014 05:21 PM, Dan Carpenter wrote:
> Smatch complains that we are reading beyond the end of the array here:
>
> drivers/gpu/drm/panel/panel-s6e8aa0.c:852 s6e8aa0_read_mtp_id()
> warn: buffer overflow 's6e8aa0_variants' 4 <= 4
>
> We set the error code, so it's not harmful but it looks like a return
> was intended here so lets add that and silence the warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> Compile tested only.
>
> diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/panel/panel-s6e8aa0.c
> index 35941d2..06e57a2 100644
> --- a/drivers/gpu/drm/panel/panel-s6e8aa0.c
> +++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c
> @@ -847,6 +847,7 @@ static void s6e8aa0_read_mtp_id(struct s6e8aa0 *ctx)
> if (i >= ARRAY_SIZE(s6e8aa0_variants)) {
> dev_err(ctx->dev, "unsupported display version %d\n", id[1]);
> ctx->error = -EINVAL;
> + return;
> }
>
> ctx->variant = &s6e8aa0_variants[i];
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] drm/panel: s6e8aa0: silence array overflow warning
2014-04-09 15:21 [patch] drm/panel: s6e8aa0: silence array overflow warning Dan Carpenter
2014-04-10 5:48 ` Andrzej Hajda
@ 2014-05-02 11:21 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2014-05-02 11:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: kernel-janitors, dri-devel, Andrzej Hajda, Rob Herring,
Grant Likely
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
On Wed, Apr 09, 2014 at 06:21:12PM +0300, Dan Carpenter wrote:
> Smatch complains that we are reading beyond the end of the array here:
>
> drivers/gpu/drm/panel/panel-s6e8aa0.c:852 s6e8aa0_read_mtp_id()
> warn: buffer overflow 's6e8aa0_variants' 4 <= 4
>
> We set the error code, so it's not harmful but it looks like a return
> was intended here so lets add that and silence the warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-02 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 15:21 [patch] drm/panel: s6e8aa0: silence array overflow warning Dan Carpenter
2014-04-10 5:48 ` Andrzej Hajda
2014-05-02 11:21 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox