* [patch] usb: gadget: f_rndis: fix an error code on allocation failure
@ 2014-05-21 12:26 Dan Carpenter
2014-05-22 5:16 ` Andrzej Pietrasiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-05-21 12:26 UTC (permalink / raw)
To: kernel-janitors
This should be return -ENOMEM. The current code returns successs.
Fixes: de7a8d2d534f ('usb: gadget: f_rndis: OS descriptors support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/gadget/f_rndis.c b/drivers/usb/gadget/f_rndis.c
index eed3ad8..31274f7 100644
--- a/drivers/usb/gadget/f_rndis.c
+++ b/drivers/usb/gadget/f_rndis.c
@@ -687,7 +687,7 @@ rndis_bind(struct usb_configuration *c, struct usb_function *f)
f->os_desc_table = kzalloc(sizeof(*f->os_desc_table),
GFP_KERNEL);
if (!f->os_desc_table)
- return PTR_ERR(f->os_desc_table);
+ return -ENOMEM;
f->os_desc_n = 1;
f->os_desc_table[0].os_desc = &rndis_opts->rndis_os_desc;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] usb: gadget: f_rndis: fix an error code on allocation failure
2014-05-21 12:26 [patch] usb: gadget: f_rndis: fix an error code on allocation failure Dan Carpenter
@ 2014-05-22 5:16 ` Andrzej Pietrasiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Pietrasiewicz @ 2014-05-22 5:16 UTC (permalink / raw)
To: kernel-janitors
W dniu 21.05.2014 14:26, Dan Carpenter pisze:
> This should be return -ENOMEM. The current code returns successs.
>
> Fixes: de7a8d2d534f ('usb: gadget: f_rndis: OS descriptors support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> diff --git a/drivers/usb/gadget/f_rndis.c b/drivers/usb/gadget/f_rndis.c
> index eed3ad8..31274f7 100644
> --- a/drivers/usb/gadget/f_rndis.c
> +++ b/drivers/usb/gadget/f_rndis.c
> @@ -687,7 +687,7 @@ rndis_bind(struct usb_configuration *c, struct usb_function *f)
> f->os_desc_table = kzalloc(sizeof(*f->os_desc_table),
> GFP_KERNEL);
> if (!f->os_desc_table)
> - return PTR_ERR(f->os_desc_table);
> + return -ENOMEM;
> f->os_desc_n = 1;
> f->os_desc_table[0].os_desc = &rndis_opts->rndis_os_desc;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-22 5:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-21 12:26 [patch] usb: gadget: f_rndis: fix an error code on allocation failure Dan Carpenter
2014-05-22 5:16 ` Andrzej Pietrasiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox