[PATCH 2/2] staging: gdm72xx: return values cleanup

[PATCH 2/2] staging: gdm72xx: return values cleanup

[Gengis Dave]

Return values cleanup

Signed-off-by: Davide Gianforte <davide@gengisdave.org>
---

 drivers/staging/gdm72xx/gdm_wimax.c | 3 +--
 drivers/staging/gdm72xx/usb_boot.c  | 5 +----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/gdm72xx/gdm_wimax.c 
b/drivers/staging/gdm72xx/gdm_wimax.c
index 245fdea..e5e5115 100644
--- a/drivers/staging/gdm72xx/gdm_wimax.c
+++ b/drivers/staging/gdm72xx/gdm_wimax.c
@@ -167,7 +167,6 @@ static inline int gdm_wimax_header(struct sk_buff **pskb)
 {
 	u16 buf[HCI_HEADER_SIZE / sizeof(u16)];
 	struct sk_buff *skb = *pskb;
-	int ret = 0;
 
 	if (unlikely(skb_headroom(skb) < HCI_HEADER_SIZE)) {
 		struct sk_buff *skb2;
@@ -187,7 +186,7 @@ static inline int gdm_wimax_header(struct sk_buff **pskb)
 	memcpy(skb->data, buf, HCI_HEADER_SIZE);
 
 	*pskb = skb;
-	return ret;
+	return 0;
 }
 
 static void gdm_wimax_event_rcv(struct net_device *dev, u16 type, void *msg,
diff --git a/drivers/staging/gdm72xx/usb_boot.c 
b/drivers/staging/gdm72xx/usb_boot.c
index 998af04..d59bac8 100644
--- a/drivers/staging/gdm72xx/usb_boot.c
+++ b/drivers/staging/gdm72xx/usb_boot.c
@@ -333,11 +333,8 @@ out:
 
 static int em_fw_reset(struct usb_device *usbdev)
 {
-	int ret;
-
 	/*Send ZLP*/
-	ret = gdm_wibro_send(usbdev, NULL, 0);
-	return ret;
+	return gdm_wibro_send(usbdev, NULL, 0);
 }
 
 int usb_emergency(struct usb_device *usbdev)

Re: [PATCH 2/2] staging: gdm72xx: return values cleanup

[Dan Carpenter]

On Fri, May 23, 2014 at 01:07:13AM +0200, Gengis Dave wrote:
> Return values cleanup
> 
> Signed-off-by: Davide Gianforte <davide@gengisdave.org>
> ---

This patch is nice, but you should really be CC'ing the
devel@driverdev.osuosl.org.

regards,
dan carpenter