[PATCH] Fixed coding style problem

[PATCH] Fixed coding style problem

[Miguel Oliveira]

Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
---
 drivers/staging/wlan-ng/p80211req.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c
index cdfd808..3b3fccc 100644
--- a/drivers/staging/wlan-ng/p80211req.c
+++ b/drivers/staging/wlan-ng/p80211req.c
@@ -109,7 +109,7 @@ int p80211req_dorequest(wlandevice_t *wlandev, u8 *msgbuf)
 	/* Check Permissions */
 	if (!capable(CAP_NET_ADMIN) &&
 	(msg->msgcode != DIDmsg_dot11req_mibget)) {
-		printk(KERN_ERR
+		netdev_err(netdev,
 		       "%s: only dot11req_mibget allowed for non-root.\n",
 		       wlandev->name);
 		return -EPERM;
--
1.7.10.4

Re: [PATCH] Fixed coding style problem

[Greg KH]

Your subject: should say where you did this.  For this example, it would
be:
	Subject: staging: wlan-ng: fixed...

Also, "what" coding style problem did you fix?


On Thu, May 29, 2014 at 10:53:56PM +0100, Miguel Oliveira wrote:
> Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>

You sould say what you did, before the signed-off-by line.

Can you fix that up and resend please?

Also use scripts/get_maintainers.pl to send to the proper people and
mailing list.

thanks,

greg k-h

Re: [PATCH] Fixed coding style problem

[Dan Carpenter]

Work against linux-next.  Someone already fixed this.  The subject
should have been:

[PATCH] staging: wlan-ng: <something something netdev_err()>

With correct prefix and a more descriptive title.  See how Vitaly did
it: http://www.spinics.net/lists/linux-driver-devel/msg46770.html

regards,
dan carpenter

Re: [PATCH] Fixed coding style problem

[Miguel Oliveira]

Thanks Dan and Greg for the hints, and sorry for this, its was my 1st
attenpt to patch something.

2014-05-29 23:03 GMT+01:00 Dan Carpenter <dan.carpenter@oracle.com>:
> Work against linux-next.  Someone already fixed this.  The subject
> should have been:
>
> [PATCH] staging: wlan-ng: <something something netdev_err()>
>
> With correct prefix and a more descriptive title.  See how Vitaly did
> it: http://www.spinics.net/lists/linux-driver-devel/msg46770.html
>
> regards,
> dan carpenter
>