* [patch] staging: comedi: amplc_pci230: fix a precedence bug
@ 2014-08-26 7:55 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-08-26 7:55 UTC (permalink / raw)
To: kernel-janitors
The addition operation has higher precedence than ?: so this would write
to PCI230_DACOUT1 instead of devpriv->daqio + PCI230_DACOUT1.
Fixes: 4f9c63fe5333 ('staging: comedi: amplc_pci230: refactor iobase addresses')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c
index 0fd212f..60d21e0 100644
--- a/drivers/staging/comedi/drivers/amplc_pci230.c
+++ b/drivers/staging/comedi/drivers/amplc_pci230.c
@@ -628,7 +628,7 @@ static inline void pci230_ao_write_nofifo(struct comedi_device *dev,
/* Write mangled datum to appropriate DACOUT register. */
outw(pci230_ao_mangle_datum(dev, datum),
- devpriv->daqio + ((chan) = 0) ? PCI230_DACOUT1 : PCI230_DACOUT2);
+ devpriv->daqio + ((chan = 0) ? PCI230_DACOUT1 : PCI230_DACOUT2));
}
static inline void pci230_ao_write_fifo(struct comedi_device *dev,
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-08-26 7:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-26 7:55 [patch] staging: comedi: amplc_pci230: fix a precedence bug Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox