* [PATCH] hid-apple: fix coding style error
@ 2014-09-03 14:08 Jonathan Klee
2014-09-03 14:40 ` Julia Lawall
2014-09-03 14:46 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Klee @ 2014-09-03 14:08 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 90 bytes --]
Hello everyone,
please find attached a patch fixing a coding style error.
Regards,
jklee
[-- Attachment #2: 0001-fix-coding-style-error.patch --]
[-- Type: text/x-patch, Size: 724 bytes --]
From e66b1e0cb9733ab20a73bb3234578006afd02639 Mon Sep 17 00:00:00 2001
From: "Jonathan Klee (jklee)" <jklee@nosuchfail.org>
Date: Wed, 3 Sep 2014 15:43:13 +0200
Subject: [PATCH] fix coding style error
---
drivers/hid/hid-apple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index f822fd2..df9348f 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -160,7 +160,7 @@ static const struct apple_key_translation swapped_option_cmd_keys[] = {
{ KEY_LEFTALT, KEY_LEFTMETA },
{ KEY_LEFTMETA, KEY_LEFTALT },
{ KEY_RIGHTALT, KEY_RIGHTMETA },
- { KEY_RIGHTMETA,KEY_RIGHTALT },
+ { KEY_RIGHTMETA, KEY_RIGHTALT },
{ }
};
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hid-apple: fix coding style error
2014-09-03 14:08 [PATCH] hid-apple: fix coding style error Jonathan Klee
@ 2014-09-03 14:40 ` Julia Lawall
2014-09-03 14:46 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2014-09-03 14:40 UTC (permalink / raw)
To: kernel-janitors
On Wed, 3 Sep 2014, Jonathan Klee wrote:
> Hello everyone,
> please find attached a patch fixing a coding style error.
Patches shouldn't be sent in attachments. Check
Documentation/SubmittingPatches
julia
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hid-apple: fix coding style error
2014-09-03 14:08 [PATCH] hid-apple: fix coding style error Jonathan Klee
2014-09-03 14:40 ` Julia Lawall
@ 2014-09-03 14:46 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-09-03 14:46 UTC (permalink / raw)
To: kernel-janitors
Thanks for the patch.
Everyone's first patch is rejected.
Don't send patches as attachments. Send them inline. Read the first
paragraph of Documentation/email-clients.txt
On Wed, Sep 03, 2014 at 04:08:16PM +0200, Jonathan Klee wrote:
> Hello everyone,
> please find attached a patch fixing a coding style error.
>
> Regards,
> jklee
> >From e66b1e0cb9733ab20a73bb3234578006afd02639 Mon Sep 17 00:00:00 2001
> From: "Jonathan Klee (jklee)" <jklee@nosuchfail.org>
> Date: Wed, 3 Sep 2014 15:43:13 +0200
> Subject: [PATCH] fix coding style error
No patch prefix.
Patch description should say something about spaces after commas.
No signed-off-by.
>
> ---
> drivers/hid/hid-apple.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index f822fd2..df9348f 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -160,7 +160,7 @@ static const struct apple_key_translation swapped_option_cmd_keys[] = {
> { KEY_LEFTALT, KEY_LEFTMETA },
> { KEY_LEFTMETA, KEY_LEFTALT },
> { KEY_RIGHTALT, KEY_RIGHTMETA },
> - { KEY_RIGHTMETA,KEY_RIGHTALT },
> + { KEY_RIGHTMETA, KEY_RIGHTALT },
The spacing here is done deliberately to make all the 'K's in the same
column. Find something else to change.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-03 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-03 14:08 [PATCH] hid-apple: fix coding style error Jonathan Klee
2014-09-03 14:40 ` Julia Lawall
2014-09-03 14:46 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox