* [patch] amdkfd: delete some dead code
@ 2014-11-25 16:43 Dan Carpenter
2014-11-26 8:57 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-11-25 16:43 UTC (permalink / raw)
To: Oded Gabbay; +Cc: kernel-janitors, dri-devel
This is dead code. We don't need to unbind here, we can just return
directly.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
index a17e2dd..b4f49ac 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
@@ -348,11 +348,6 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev,
if (err < 0)
return ERR_PTR(err);
- if (err < 0) {
- amd_iommu_unbind_pasid(dev->pdev, p->pasid);
- return ERR_PTR(err);
- }
-
pdd->bound = true;
return pdd;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] amdkfd: delete some dead code
2014-11-25 16:43 [patch] amdkfd: delete some dead code Dan Carpenter
@ 2014-11-26 8:57 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2014-11-26 8:57 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, dri-devel
On 11/25/2014 06:43 PM, Dan Carpenter wrote:
> This is dead code. We don't need to unbind here, we can just return
> directly.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
And applied to my 3.19-next-wip tree.
Thanks!
Oded
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index a17e2dd..b4f49ac 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -348,11 +348,6 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev,
> if (err < 0)
> return ERR_PTR(err);
>
> - if (err < 0) {
> - amd_iommu_unbind_pasid(dev->pdev, p->pasid);
> - return ERR_PTR(err);
> - }
> -
> pdd->bound = true;
>
> return pdd;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-26 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-25 16:43 [patch] amdkfd: delete some dead code Dan Carpenter
2014-11-26 8:57 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox