[patch] x86_64, traps: always true condition

[patch] x86_64, traps: always true condition

[Dan Carpenter]

We should be checking IS_ERR() here.  PTR_ERR() is always true.

Fixes: b645af2d5905 ('x86_64, traps: Rework bad_iret')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 67d817e..f176d96 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -331,7 +331,7 @@ dotraplinkage void do_bounds(struct pt_regs *regs, long error_code)
 		break; /* Success, it was handled */
 	case 1: /* Bound violation. */
 		info = mpx_generate_siginfo(regs, xsave_buf);
-		if (PTR_ERR(info)) {
+		if (IS_ERR(info)) {
 			/*
 			 * We failed to decode the MPX instruction.  Act as if
 			 * the exception was not caused by MPX.

Re: [patch] x86_64, traps: always true condition

[Dan Carpenter]

On Tue, Nov 25, 2014 at 09:12:35AM -0800, Andy Lutomirski wrote:
> On Nov 25, 2014 8:44 AM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
> >
> > We should be checking IS_ERR() here.  PTR_ERR() is always true.
> >
> > Fixes: b645af2d5905 ('x86_64, traps: Rework bad_iret')
> 
> Huh?
> 
> I agree with the change, but the Fixes line looks wrong.
> 


Oops.  Sorry for that, it was the fe3d197f8431 ('x86, mpx: On-demand
kernel allocation of bounds tables') change.  I will resend.

regards,
dan carpenter