* [patch v2] x86_64, traps: always true condition
@ 2014-11-25 17:21 Dan Carpenter
2014-12-04 21:33 ` Dave Hansen
2014-12-04 21:56 ` Dave Hansen
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-11-25 17:21 UTC (permalink / raw)
To: kernel-janitors
We should be checking IS_ERR() here. PTR_ERR() is always true.
Fixes: fe3d197f8431 ('x86, mpx: On-demand kernel allocation of bounds tables')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Use correct fixes tag.
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 67d817e..f176d96 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -331,7 +331,7 @@ dotraplinkage void do_bounds(struct pt_regs *regs, long error_code)
break; /* Success, it was handled */
case 1: /* Bound violation. */
info = mpx_generate_siginfo(regs, xsave_buf);
- if (PTR_ERR(info)) {
+ if (IS_ERR(info)) {
/*
* We failed to decode the MPX instruction. Act as if
* the exception was not caused by MPX.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch v2] x86_64, traps: always true condition
2014-11-25 17:21 [patch v2] x86_64, traps: always true condition Dan Carpenter
@ 2014-12-04 21:33 ` Dave Hansen
2014-12-04 21:56 ` Dave Hansen
1 sibling, 0 replies; 3+ messages in thread
From: Dave Hansen @ 2014-12-04 21:33 UTC (permalink / raw)
To: kernel-janitors
On 11/25/2014 09:21 AM, Dan Carpenter wrote:
> We should be checking IS_ERR() here. PTR_ERR() is always true.
>
> Fixes: fe3d197f8431 ('x86, mpx: On-demand kernel allocation of bounds tables')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Use correct fixes tag.
>
> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> index 67d817e..f176d96 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -331,7 +331,7 @@ dotraplinkage void do_bounds(struct pt_regs *regs, long error_code)
> break; /* Success, it was handled */
> case 1: /* Bound violation. */
> info = mpx_generate_siginfo(regs, xsave_buf);
> - if (PTR_ERR(info)) {
> + if (IS_ERR(info)) {
> /*
> * We failed to decode the MPX instruction. Act as if
> * the exception was not caused by MPX.
I checked that this works on real hardware. The si_addr field in the
generated siginfo was empty without this patch applied. With this
patch, it has good (looking at least) contents.
Thanks for catching this!
Tested-by: Dave Hansen <dave.hansen@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch v2] x86_64, traps: always true condition
2014-11-25 17:21 [patch v2] x86_64, traps: always true condition Dan Carpenter
2014-12-04 21:33 ` Dave Hansen
@ 2014-12-04 21:56 ` Dave Hansen
1 sibling, 0 replies; 3+ messages in thread
From: Dave Hansen @ 2014-12-04 21:56 UTC (permalink / raw)
To: kernel-janitors
On 11/25/2014 09:21 AM, Dan Carpenter wrote:
> We should be checking IS_ERR() here. PTR_ERR() is always true.
>
> Fixes: fe3d197f8431 ('x86, mpx: On-demand kernel allocation of bounds
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Use correct fixes tag.
>
> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> index 67d817e..f176d96 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -331,7 +331,7 @@ dotraplinkage void do_bounds(struct pt_regs >
break; /* Success, it was handled */
> case 1: /* Bound violation. */
> info = mpx_generate_siginfo(regs, xsave_buf);
> - if (PTR_ERR(info)) {
> + if (IS_ERR(info)) {
> /*
> * We failed to decode the MPX instruction.
> * the exception was not caused by MPX.
I checked that this works on real hardware. The si_addr field in the
generated siginfo was empty without this patch applied. With this
patch, it has good (looking at least) contents.
Thanks for catching this!
Tested-by: Dave Hansen <dave.hansen@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-04 21:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-25 17:21 [patch v2] x86_64, traps: always true condition Dan Carpenter
2014-12-04 21:33 ` Dave Hansen
2014-12-04 21:56 ` Dave Hansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox