* [patch] staging: fbtft: fix allyesconfig build
@ 2015-01-23 14:20 Dan Carpenter
2015-01-23 19:45 ` Jim Davis
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-01-23 14:20 UTC (permalink / raw)
To: kernel-janitors
There are two functions call reset() so the allyesconfig breaks. Let's
make this one static.
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Hi Jim, can you test this patch and see if it fixes the build issue?
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
index 7fe4fa0..9cc7d25 100644
--- a/drivers/staging/fbtft/fb_agm1264k-fl.c
+++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
@@ -89,7 +89,7 @@ static int init_display(struct fbtft_par *par)
return 0;
}
-void reset(struct fbtft_par *par)
+static void reset(struct fbtft_par *par)
{
if (par->gpio.reset = -1)
return;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] staging: fbtft: fix allyesconfig build
2015-01-23 14:20 [patch] staging: fbtft: fix allyesconfig build Dan Carpenter
@ 2015-01-23 19:45 ` Jim Davis
0 siblings, 0 replies; 2+ messages in thread
From: Jim Davis @ 2015-01-23 19:45 UTC (permalink / raw)
To: kernel-janitors
On Fri, Jan 23, 2015 at 7:20 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There are two functions call reset() so the allyesconfig breaks. Let's
> make this one static.
>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Hi Jim, can you test this patch and see if it fixes the build issue?
>
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index 7fe4fa0..9cc7d25 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -89,7 +89,7 @@ static int init_display(struct fbtft_par *par)
> return 0;
> }
>
> -void reset(struct fbtft_par *par)
> +static void reset(struct fbtft_par *par)
> {
> if (par->gpio.reset = -1)
> return;
> --
Looks good -- make allyesconfig with next-20150123 builds cleanly with
that patch. Thanks!
Tested-by: Jim Davis <jim.epost@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-23 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-23 14:20 [patch] staging: fbtft: fix allyesconfig build Dan Carpenter
2015-01-23 19:45 ` Jim Davis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox