* [PATCH 1/1] staging: android: Remove allocation from declaration line
@ 2015-02-10 11:09 Quentin Lambert
2015-02-10 22:24 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Quentin Lambert @ 2015-02-10 11:09 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hj�nnev�g, Riley Andrews
Cc: kernel-janitors, devel, linux-kernel
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/android/ion/ion_page_pool.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
index 4b88f11..7643d83 100644
--- a/drivers/staging/android/ion/ion_page_pool.c
+++ b/drivers/staging/android/ion/ion_page_pool.c
@@ -148,8 +148,9 @@ int ion_page_pool_shrink(struct ion_page_pool *pool, gfp_t gfp_mask,
struct ion_page_pool *ion_page_pool_create(gfp_t gfp_mask, unsigned int order)
{
- struct ion_page_pool *pool = kmalloc(sizeof(struct ion_page_pool),
- GFP_KERNEL);
+ struct ion_page_pool *pool;
+
+ pool = kmalloc(sizeof(struct ion_page_pool), GFP_KERNEL);
if (!pool)
return NULL;
pool->high_count = 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] staging: android: Remove allocation from declaration line
2015-02-10 11:09 [PATCH 1/1] staging: android: Remove allocation from declaration line Quentin Lambert
@ 2015-02-10 22:24 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2015-02-10 22:24 UTC (permalink / raw)
To: Quentin Lambert
Cc: Arve Hj�nnev�g, Riley Andrews, kernel-janitors,
devel, linux-kernel
On Tue, Feb 10, 2015 at 12:09:45PM +0100, Quentin Lambert wrote:
> This patch removes allocation from declaration line because
> people are known to gloss over declarations.
Then those people should not be reviewing kernel code :)
Seriously, this is unneeded churn, the code is fine as-is.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-10 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-10 11:09 [PATCH 1/1] staging: android: Remove allocation from declaration line Quentin Lambert
2015-02-10 22:24 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox