* [patch] RDMA/ocrdma: off by one in ocrdma_query_gid()
@ 2012-06-14 18:36 Dan Carpenter
[not found] ` <20120614183609.GE6383-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2015-02-16 10:01 ` Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-06-14 18:36 UTC (permalink / raw)
To: Roland Dreier
Cc: Sean Hefty, Hal Rosenstock, Parav Pandit, Mahesh Vardhamanaiah,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
The dev->sgid_tbl[] array is allocated in ocrdma_alloc_resources(). It
has OCRDMA_MAX_SGID elements so the test here is off by one.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index d55d459..2e2e7ae 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -53,7 +53,7 @@ int ocrdma_query_gid(struct ib_device *ibdev, u8 port,
dev = get_ocrdma_dev(ibdev);
memset(sgid, 0, sizeof(*sgid));
- if (index > OCRDMA_MAX_SGID)
+ if (index >= OCRDMA_MAX_SGID)
return -EINVAL;
memcpy(sgid, &dev->sgid_tbl[index], sizeof(*sgid));
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <20120614183609.GE6383-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>]
* [patch] RDMA/ocrdma: off by one in ocrdma_query_gid()
2012-06-14 18:36 [patch] RDMA/ocrdma: off by one in ocrdma_query_gid() Dan Carpenter
[not found] ` <20120614183609.GE6383-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2015-02-16 10:01 ` Dan Carpenter
2015-02-17 5:32 ` Selvin Xavier
1 sibling, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2015-02-16 10:01 UTC (permalink / raw)
To: Roland Dreier
Cc: Sean Hefty, Hal Rosenstock, Devesh Sharma, Selvin Xavier,
Mitesh Ahuja, Yishai Hadas, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
The ->sgid_tbl[] array has OCRDMA_MAX_SGID number of elements so this
test is off by one. ->sgid_tbl is allocated in ocrdma_alloc_resources().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index fb8d8c4..18ea619 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -53,7 +53,7 @@ int ocrdma_query_gid(struct ib_device *ibdev, u8 port,
dev = get_ocrdma_dev(ibdev);
memset(sgid, 0, sizeof(*sgid));
- if (index > OCRDMA_MAX_SGID)
+ if (index >= OCRDMA_MAX_SGID)
return -EINVAL;
memcpy(sgid, &dev->sgid_tbl[index], sizeof(*sgid));
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [patch] RDMA/ocrdma: off by one in ocrdma_query_gid()
2015-02-16 10:01 ` Dan Carpenter
@ 2015-02-17 5:32 ` Selvin Xavier
0 siblings, 0 replies; 4+ messages in thread
From: Selvin Xavier @ 2015-02-17 5:32 UTC (permalink / raw)
To: Dan Carpenter, Roland Dreier
Cc: Sean Hefty, Hal Rosenstock, Devesh Sharma, Mitesh Ahuja,
Yishai Hadas, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Acked-by: Selvin Xavier <selvin.xavier@emulex.com>
Thanks !
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Monday, February 16, 2015 3:32 PM
> To: Roland Dreier
> Cc: Sean Hefty; Hal Rosenstock; Devesh Sharma; Selvin Xavier; Mitesh Ahuja;
> Yishai Hadas; linux-rdma@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] RDMA/ocrdma: off by one in ocrdma_query_gid()
>
> The ->sgid_tbl[] array has OCRDMA_MAX_SGID number of elements so this
> test is off by one. ->sgid_tbl is allocated in ocrdma_alloc_resources().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index fb8d8c4..18ea619 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -53,7 +53,7 @@ int ocrdma_query_gid(struct ib_device *ibdev, u8 port,
>
> dev = get_ocrdma_dev(ibdev);
> memset(sgid, 0, sizeof(*sgid));
> - if (index > OCRDMA_MAX_SGID)
> + if (index >= OCRDMA_MAX_SGID)
> return -EINVAL;
>
> memcpy(sgid, &dev->sgid_tbl[index], sizeof(*sgid));
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-17 5:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-14 18:36 [patch] RDMA/ocrdma: off by one in ocrdma_query_gid() Dan Carpenter
[not found] ` <20120614183609.GE6383-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-06-14 20:27 ` Roland Dreier
2015-02-16 10:01 ` Dan Carpenter
2015-02-17 5:32 ` Selvin Xavier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox