From: Ingo Molnar <mingo@kernel.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] watchdog: double lock typo in watchdog_nmi_enable_all()
Date: Wed, 20 May 2015 08:17:34 +0000 [thread overview]
Message-ID: <20150520081734.GA25966@gmail.com> (raw)
In-Reply-To: <20150520074408.GC18278@mwanda>
* Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The mutex_lock() should obviously be mutex_unlock().
>
> Fixes: ab992dc38f9a ('watchdog: Fix merge 'conflict'')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This bug is already in mainline.
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index c57e67d..a6ffa43 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -628,7 +628,7 @@ void watchdog_nmi_enable_all(void)
> put_online_cpus();
>
> unlock:
> - mutex_lock(&watchdog_proc_mutex);
> + mutex_unlock(&watchdog_proc_mutex);
> }
>
> void watchdog_nmi_disable_all(void)
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2015-05-20 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 7:44 [patch] watchdog: double lock typo in watchdog_nmi_enable_all() Dan Carpenter
2015-05-20 8:17 ` Ingo Molnar [this message]
2015-05-20 11:19 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520081734.GA25966@gmail.com \
--to=mingo@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox