* [patch] drm/virtio: remove some dead code
@ 2015-06-10 19:27 Dan Carpenter
2015-06-11 6:17 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-06-10 19:27 UTC (permalink / raw)
To: David Airlie; +Cc: kernel-janitors, dri-devel, virtualization
The goto is correct, and we never reach the return statement so just
delete the dead code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
index e0e74c6..b092d7b 100644
--- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
+++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
@@ -443,14 +443,12 @@ int virtio_gpu_ttm_init(struct virtio_gpu_device *vgdev)
if (r) {
DRM_ERROR("failed initializing buffer object driver(%d).\n", r);
goto err_dev_init;
- return r;
}
r = ttm_bo_init_mm(&vgdev->mman.bdev, TTM_PL_TT, 0);
if (r) {
DRM_ERROR("Failed initializing GTT heap.\n");
goto err_mm_init;
- return r;
}
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] drm/virtio: remove some dead code
2015-06-10 19:27 [patch] drm/virtio: remove some dead code Dan Carpenter
@ 2015-06-11 6:17 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2015-06-11 6:17 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, dri-devel, virtualization, kernel-janitors
On Mi, 2015-06-10 at 22:27 +0300, Dan Carpenter wrote:
> The goto is correct, and we never reach the return statement so just
> delete the dead code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-11 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-10 19:27 [patch] drm/virtio: remove some dead code Dan Carpenter
2015-06-11 6:17 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox