* [patch] spi: zynq: missing break statement
@ 2015-06-24 14:31 Dan Carpenter
2015-06-25 8:32 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-06-24 14:31 UTC (permalink / raw)
To: Mark Brown, Ranjit Waghmode
Cc: Michal Simek, Sören Brinkmann, linux-spi, kernel-janitors
There is a missing break statement here so selecting both only selects
upper.
Fixes: dfe11a11d523 ('spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
index 87b20a5..f23f36e 100644
--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -214,6 +214,7 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
case GQSPI_SELECT_FLASH_CS_BOTH:
instanceptr->genfifocs = GQSPI_GENFIFO_CS_LOWER |
GQSPI_GENFIFO_CS_UPPER;
+ break;
case GQSPI_SELECT_FLASH_CS_UPPER:
instanceptr->genfifocs = GQSPI_GENFIFO_CS_UPPER;
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] spi: zynq: missing break statement
2015-06-24 14:31 [patch] spi: zynq: missing break statement Dan Carpenter
@ 2015-06-25 8:32 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2015-06-25 8:32 UTC (permalink / raw)
To: Dan Carpenter, Mark Brown, Ranjit Waghmode
Cc: Michal Simek, Sören Brinkmann,
linux-spi-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On 06/24/2015 04:31 PM, Dan Carpenter wrote:
> There is a missing break statement here so selecting both only selects
> upper.
>
> Fixes: dfe11a11d523 ('spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index 87b20a5..f23f36e 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -214,6 +214,7 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
> case GQSPI_SELECT_FLASH_CS_BOTH:
> instanceptr->genfifocs = GQSPI_GENFIFO_CS_LOWER |
> GQSPI_GENFIFO_CS_UPPER;
> + break;
> case GQSPI_SELECT_FLASH_CS_UPPER:
> instanceptr->genfifocs = GQSPI_GENFIFO_CS_UPPER;
> break;
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-25 8:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-24 14:31 [patch] spi: zynq: missing break statement Dan Carpenter
2015-06-25 8:32 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox