* Re: [PATCH v2 2/3] Staging: android: ion: fix coding style
2015-07-01 13:58 ` [PATCH v2 2/3] Staging: android: ion: fix coding style Sohny Thomas
@ 2015-07-01 14:18 ` Frans Klaver
2015-07-01 14:29 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Frans Klaver @ 2015-07-01 14:18 UTC (permalink / raw)
To: Sohny Thomas
Cc: Greg KH, arve, riandrews, Sumit Semwal, carlos, kernel-janitors,
linux-kernel@vger.kernel.org
On Wed, Jul 1, 2015 at 3:46 PM, Sohny Thomas <sohnythomas@zoho.com> wrote:
>
> - Fixed 80 char limit exceeding line
> and a newline after declarations as per checkpatch.pl
>
> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
You can remove the dash, and fix the -off- typo (hint: use 'git commit
-s' for automating it). Maybe hint towards what coding style is fixed
in the summary:
staging: android: ion: fix line over 80 characters
> ---
> drivers/staging/android/ion/ion.c | 1 +
> drivers/staging/android/ion/ion_chunk_heap.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 6f48112..e44f5e6 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> struct ion_buffer *buffer;
> struct dma_buf *dmabuf;
> bool valid_handle;
> +
> DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
>
> mutex_lock(&client->lock);
> diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c
> index 5474615..0813163 100644
> --- a/drivers/staging/android/ion/ion_chunk_heap.c
> +++ b/drivers/staging/android/ion/ion_chunk_heap.c
> @@ -173,8 +173,8 @@ struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data)
> chunk_heap->heap.ops = &chunk_heap_ops;
> chunk_heap->heap.type = ION_HEAP_TYPE_CHUNK;
> chunk_heap->heap.flags = ION_HEAP_FLAG_DEFER_FREE;
> - pr_debug("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base,
> - heap_data->size, heap_data->align);
> + pr_debug("%s: base %lu size %zu align %ld\n", __func__,
> + chunk_heap->base, heap_data->size, heap_data->align);
>
> return &chunk_heap->heap;
>
> --
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 2/3] Staging: android: ion: fix coding style
2015-07-01 13:58 ` [PATCH v2 2/3] Staging: android: ion: fix coding style Sohny Thomas
2015-07-01 14:18 ` Frans Klaver
@ 2015-07-01 14:29 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-07-01 14:29 UTC (permalink / raw)
To: Sohny Thomas
Cc: gregkh, arve, riandrews, sumit.semwal, carlos, kernel-janitors,
linux-kernel@vger.kernel.org
On Wed, Jul 01, 2015 at 07:16:44PM +0530, Sohny Thomas wrote:
>
> - Fixed 80 char limit exceeding line
> and a newline after declarations as per checkpatch.pl
>
> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
> ---
> drivers/staging/android/ion/ion.c | 1 +
> drivers/staging/android/ion/ion_chunk_heap.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 6f48112..e44f5e6 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
> struct ion_buffer *buffer;
> struct dma_buf *dmabuf;
> bool valid_handle;
> +
> DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
>
> mutex_lock(&client->lock);
This is a false positive in checkpatch.pl. Just leave it as is.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread