[patch] fuse: fix an error code in fuse_lookup_name()

[patch] fuse: fix an error code in fuse_lookup_name()

[Dan Carpenter]

This is a static checker fix because we check "outarg->nodeid" here and
then again a in the next if statement.  The difference is that for this
first one we don't set the error code.

Fixes: c180eebe1390 ('fuse: add fuse_lookup_name() helper')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index 5e2e087..225fc703 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -306,8 +306,7 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, struct qstr *name,
 
 	fuse_lookup_init(fc, &args, nodeid, name, outarg);
 	err = fuse_simple_request(fc, &args);
-	/* Zero nodeid is same as -ENOENT, but with valid timeout */
-	if (err || !outarg->nodeid)
+	if (err)
 		goto out_put_forget;
 
 	err = -EIO;

Re: [fuse-devel] [patch] fuse: fix an error code in fuse_lookup_name()

[Ashish Samant]

Reviewed-by: Ashish Samant <ashish.samant@oracle.com>
On 08/08/2015 06:01 AM, Dan Carpenter wrote:
> This is a static checker fix because we check "outarg->nodeid" here and
> then again a in the next if statement.  The difference is that for this
> first one we don't set the error code.
>
> Fixes: c180eebe1390 ('fuse: add fuse_lookup_name() helper')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index 5e2e087..225fc703 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -306,8 +306,7 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, struct qstr *name,
>   
>   	fuse_lookup_init(fc, &args, nodeid, name, outarg);
>   	err = fuse_simple_request(fc, &args);
> -	/* Zero nodeid is same as -ENOENT, but with valid timeout */
> -	if (err || !outarg->nodeid)
> +	if (err)
>   		goto out_put_forget;
>   
>   	err = -EIO;
>
> ------------------------------------------------------------------------------
> _______________________________________________
> fuse-devel mailing list
> fuse-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/fuse-devel
>

Re: [fuse-devel] [patch] fuse: fix an error code in fuse_lookup_name()

[Miklos Szeredi]

> On 08/08/2015 06:01 AM, Dan Carpenter wrote:
>>
>> This is a static checker fix because we check "outarg->nodeid" here and
>> then again a in the next if statement.  The difference is that for this
>> first one we don't set the error code.

Except for the fact that zero error code is correct (as the comment
indicates) and EIO would be wrong.  So the patch actually breaks the
code, not fixes it.

Thanks,
Miklos

>>
>> Fixes: c180eebe1390 ('fuse: add fuse_lookup_name() helper')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
>> index 5e2e087..225fc703 100644
>> --- a/fs/fuse/dir.c
>> +++ b/fs/fuse/dir.c
>> @@ -306,8 +306,7 @@ int fuse_lookup_name(struct super_block *sb, u64
>> nodeid, struct qstr *name,
>>         fuse_lookup_init(fc, &args, nodeid, name, outarg);
>>         err = fuse_simple_request(fc, &args);
>> -       /* Zero nodeid is same as -ENOENT, but with valid timeout */
>> -       if (err || !outarg->nodeid)
>> +       if (err)
>>                 goto out_put_forget;
>>         err = -EIO;
>>
>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> fuse-devel mailing list
>> fuse-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/fuse-devel
>>
>