* [patch] drm/amdgpu: signedness bug in amdgpu_cs_parser_init() [not found] <A3397C8B8B789E45844E7EC5DEAD89D06E91395A@satlexdag05.amd.com> @ 2015-09-25 11:36 ` Dan Carpenter 2015-09-29 17:44 ` Alex Deucher 0 siblings, 1 reply; 2+ messages in thread From: Dan Carpenter @ 2015-09-25 11:36 UTC (permalink / raw) To: David Airlie Cc: Christian König, Chunming Zhou, Alex Deucher, Jammy Zhou, monk.liu, Marek Olšák, dri-devel, kernel-janitors, security, Ilja Van Sprundel The "i" variable should be signed or it leads to a crash in the error handling code. Fixes: 1d263474c441 ('drm/amdgpu: unwind properly in amdgpu_cs_parser_init()') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 749420f..cb3c274 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -156,7 +156,8 @@ int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, void *data) uint64_t *chunk_array_user; uint64_t *chunk_array; struct amdgpu_fpriv *fpriv = p->filp->driver_priv; - unsigned size, i; + unsigned size; + int i; int ret; if (cs->in.num_chunks = 0) ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] drm/amdgpu: signedness bug in amdgpu_cs_parser_init() 2015-09-25 11:36 ` [patch] drm/amdgpu: signedness bug in amdgpu_cs_parser_init() Dan Carpenter @ 2015-09-29 17:44 ` Alex Deucher 0 siblings, 0 replies; 2+ messages in thread From: Alex Deucher @ 2015-09-29 17:44 UTC (permalink / raw) To: Dan Carpenter Cc: security, Marek Olšák, Ilja Van Sprundel, kernel-janitors, Maling list - DRI developers, Alex Deucher, Christian König, monk.liu On Fri, Sep 25, 2015 at 7:36 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > The "i" variable should be signed or it leads to a crash in the error > handling code. > > Fixes: 1d263474c441 ('drm/amdgpu: unwind properly in amdgpu_cs_parser_init()') > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied. thanks! Alex > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > index 749420f..cb3c274 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > @@ -156,7 +156,8 @@ int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, void *data) > uint64_t *chunk_array_user; > uint64_t *chunk_array; > struct amdgpu_fpriv *fpriv = p->filp->driver_priv; > - unsigned size, i; > + unsigned size; > + int i; > int ret; > > if (cs->in.num_chunks = 0) > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-29 17:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <A3397C8B8B789E45844E7EC5DEAD89D06E91395A@satlexdag05.amd.com>
2015-09-25 11:36 ` [patch] drm/amdgpu: signedness bug in amdgpu_cs_parser_init() Dan Carpenter
2015-09-29 17:44 ` Alex Deucher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox