* [patch] nl802154: Missing return in nl802154_add_llsec_key()
[not found] <20151002071958.GA565@omega>
@ 2015-10-02 7:47 ` Dan Carpenter
2015-10-02 10:37 ` Alexander Aring
2015-10-02 21:35 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-10-02 7:47 UTC (permalink / raw)
To: Alexander Aring; +Cc: linux-wpan, Marcel Holtmann, kernel-janitors
There was a missing return here so it meant that often
ieee802154_llsec_parse_key_id() was not called.
Fixes: a26c5fd7622d ('nl802154: add support for security layer')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index 1e9e865..16ef0d9 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -1534,6 +1534,7 @@ static int nl802154_add_llsec_key(struct sk_buff *skb, struct genl_info *info)
if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] ||
!attrs[NL802154_KEY_ATTR_BYTES])
+ return -EINVAL;
if (ieee802154_llsec_parse_key_id(attrs[NL802154_KEY_ATTR_ID], &id) < 0)
return -ENOBUFS;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] nl802154: Missing return in nl802154_add_llsec_key()
2015-10-02 7:47 ` [patch] nl802154: Missing return in nl802154_add_llsec_key() Dan Carpenter
@ 2015-10-02 10:37 ` Alexander Aring
2015-10-02 21:35 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Aring @ 2015-10-02 10:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-wpan, Marcel Holtmann, kernel-janitors
Hi,
On Fri, Oct 02, 2015 at 10:47:29AM +0300, Dan Carpenter wrote:
> There was a missing return here so it meant that often
> ieee802154_llsec_parse_key_id() was not called.
>
> Fixes: a26c5fd7622d ('nl802154: add support for security layer')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Thanks.
- Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] nl802154: Missing return in nl802154_add_llsec_key()
2015-10-02 7:47 ` [patch] nl802154: Missing return in nl802154_add_llsec_key() Dan Carpenter
2015-10-02 10:37 ` Alexander Aring
@ 2015-10-02 21:35 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2015-10-02 21:35 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Alexander Aring, linux-wpan, kernel-janitors
Hi Dan,
> There was a missing return here so it meant that often
> ieee802154_llsec_parse_key_id() was not called.
>
> Fixes: a26c5fd7622d ('nl802154: add support for security layer')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-02 21:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151002071958.GA565@omega>
2015-10-02 7:47 ` [patch] nl802154: Missing return in nl802154_add_llsec_key() Dan Carpenter
2015-10-02 10:37 ` Alexander Aring
2015-10-02 21:35 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox