* [patch] ASoC: wm8960: harmless underflow in wm8960_put_deemph()
@ 2015-10-13 7:09 Dan Carpenter
2015-10-13 7:09 ` Dan Carpenter
2015-10-13 12:28 ` Charles Keepax
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-10-13 7:09 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Charles Keepax,
Zidan Wang, Lars-Peter Clausen, Krzysztof Kozlowski, patches,
alsa-devel, kernel-janitors
We should only accept "deemph" values of zero and one, but by mistake we
accept negatives as well. It's harmless but let's clean it up anyway.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index e3b7d0c..dc47c2f 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -201,7 +201,7 @@ static int wm8960_put_deemph(struct snd_kcontrol *kcontrol,
{
struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
- int deemph = ucontrol->value.integer.value[0];
+ unsigned int deemph = ucontrol->value.integer.value[0];
if (deemph > 1)
return -EINVAL;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] ASoC: wm8960: harmless underflow in wm8960_put_deemph()
2015-10-13 7:09 [patch] ASoC: wm8960: harmless underflow in wm8960_put_deemph() Dan Carpenter
@ 2015-10-13 7:09 ` Dan Carpenter
2015-10-22 12:56 ` Mark Brown
2015-10-13 12:28 ` Charles Keepax
1 sibling, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2015-10-13 7:09 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Zidan Wang,
Charles Keepax, Lars-Peter Clausen, Krzysztof Kozlowski, patches,
alsa-devel, kernel-janitors
Valid values of "deemph" are zero and one, but we accidentally allow
negative values as well. It's harmless but we may as well fix it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index e3b7d0c..dc47c2f 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -201,7 +201,7 @@ static int wm8960_put_deemph(struct snd_kcontrol *kcontrol,
{
struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
- int deemph = ucontrol->value.integer.value[0];
+ unsigned int deemph = ucontrol->value.integer.value[0];
if (deemph > 1)
return -EINVAL;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] ASoC: wm8960: harmless underflow in wm8960_put_deemph()
2015-10-13 7:09 [patch] ASoC: wm8960: harmless underflow in wm8960_put_deemph() Dan Carpenter
2015-10-13 7:09 ` Dan Carpenter
@ 2015-10-13 12:28 ` Charles Keepax
1 sibling, 0 replies; 4+ messages in thread
From: Charles Keepax @ 2015-10-13 12:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Zidan Wang, Lars-Peter Clausen, Krzysztof Kozlowski, patches,
alsa-devel, kernel-janitors
On Tue, Oct 13, 2015 at 10:09:19AM +0300, Dan Carpenter wrote:
> We should only accept "deemph" values of zero and one, but by mistake we
> accept negatives as well. It's harmless but let's clean it up anyway.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] ASoC: wm8960: harmless underflow in wm8960_put_deemph()
2015-10-13 7:09 ` Dan Carpenter
@ 2015-10-22 12:56 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-10-22 12:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Zidan Wang,
Charles Keepax, Lars-Peter Clausen, Krzysztof Kozlowski, patches,
alsa-devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
On Tue, Oct 13, 2015 at 10:09:38AM +0300, Dan Carpenter wrote:
> Valid values of "deemph" are zero and one, but we accidentally allow
> negative values as well. It's harmless but we may as well fix it.
This appears to duplicate the patch sent immediately before it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-22 12:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 7:09 [patch] ASoC: wm8960: harmless underflow in wm8960_put_deemph() Dan Carpenter
2015-10-13 7:09 ` Dan Carpenter
2015-10-22 12:56 ` Mark Brown
2015-10-13 12:28 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox