* [patch] ASoC: es8328: harmless underflow in es8328_put_deemph()
@ 2015-10-13 7:11 Dan Carpenter
2015-10-22 12:58 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-10-13 7:11 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Lars-Peter Clausen,
Wei Yongjun, alsa-devel, kernel-janitors
Valid values for "deemph" are zero and one but we accidentally allow
negative values as well. It's harmless but it causes static checker
warnings and we may as well clean it up.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c
index 6a09101..969e337 100644
--- a/sound/soc/codecs/es8328.c
+++ b/sound/soc/codecs/es8328.c
@@ -129,7 +129,7 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol,
{
struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
struct es8328_priv *es8328 = snd_soc_codec_get_drvdata(codec);
- int deemph = ucontrol->value.integer.value[0];
+ unsigned int deemph = ucontrol->value.integer.value[0];
int ret;
if (deemph > 1)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] ASoC: es8328: harmless underflow in es8328_put_deemph()
2015-10-13 7:11 [patch] ASoC: es8328: harmless underflow in es8328_put_deemph() Dan Carpenter
@ 2015-10-22 12:58 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-10-22 12:58 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Lars-Peter Clausen,
Wei Yongjun, alsa-devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On Tue, Oct 13, 2015 at 10:11:09AM +0300, Dan Carpenter wrote:
> Valid values for "deemph" are zero and one but we accidentally allow
> negative values as well. It's harmless but it causes static checker
> warnings and we may as well clean it up.
Thanks for all these fixes. It almost feels like someone should
volunteer to implement these deemphasis controls in some generic
fashion! :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-22 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 7:11 [patch] ASoC: es8328: harmless underflow in es8328_put_deemph() Dan Carpenter
2015-10-22 12:58 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox